Skip to content

Commit 9fa7fe1

Browse files
authored
Add missing match on metadata location translation (#6972)
1 parent 45a5073 commit 9fa7fe1

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

src/Build.UnitTests/TestComparers/ProjectInstanceModelTestComparers.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,12 @@ public bool Equals(ProjectItemGroupTaskItemInstance x, ProjectItemGroupTaskItemI
183183
Assert.Equal(x.RemoveMetadataLocation, y.RemoveMetadataLocation, new Helpers.ElementLocationComparerIgnoringType());
184184
Assert.Equal(x.ConditionLocation, y.ConditionLocation, new Helpers.ElementLocationComparerIgnoringType());
185185

186+
Assert.Equal(x.MatchOnMetadata, y.MatchOnMetadata);
187+
Assert.Equal(x.MatchOnMetadataLocation, y.MatchOnMetadataLocation, new Helpers.ElementLocationComparerIgnoringType());
188+
189+
Assert.Equal(x.MatchOnMetadataOptions, y.MatchOnMetadataOptions);
190+
Assert.Equal(x.MatchOnMetadataOptionsLocation, y.MatchOnMetadataOptionsLocation, new Helpers.ElementLocationComparerIgnoringType());
191+
186192
Assert.Equal(x.Metadata, y.Metadata, new TargetItemMetadataComparer());
187193

188194
return true;

src/Build/Instance/ProjectItemGroupTaskItemInstance.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -459,6 +459,8 @@ void ITranslatable.Translate(ITranslator translator)
459459
translator.Translate(ref _keepMetadataLocation, ElementLocation.FactoryForDeserialization);
460460
translator.Translate(ref _removeMetadataLocation, ElementLocation.FactoryForDeserialization);
461461
translator.Translate(ref _keepDuplicatesLocation, ElementLocation.FactoryForDeserialization);
462+
translator.Translate(ref _matchOnMetadataLocation, ElementLocation.FactoryForDeserialization);
463+
translator.Translate(ref _matchOnMetadataOptionsLocation, ElementLocation.FactoryForDeserialization);
462464
translator.Translate(ref _conditionLocation, ElementLocation.FactoryForDeserialization);
463465
translator.Translate(ref _metadata, ProjectItemGroupTaskMetadataInstance.FactoryForDeserialization);
464466
}

0 commit comments

Comments
 (0)