From bbaebae3a9fabc08b201e7cec94aa2808f931555 Mon Sep 17 00:00:00 2001 From: Rolf Bjarne Kvinge Date: Thu, 28 Nov 2024 18:21:07 +0100 Subject: [PATCH 1/2] [AuthenticationServices] Implement XCode 16.2 beta 1-3 changes. --- src/authenticationservices.cs | 4 ++++ tests/cecil-tests/Documentation.KnownFailures.txt | 2 ++ .../MacCatalyst-AuthenticationServices.todo | 2 -- .../api-annotations-dotnet/iOS-AuthenticationServices.todo | 2 -- .../api-annotations-dotnet/macOS-AuthenticationServices.todo | 2 -- 5 files changed, 6 insertions(+), 6 deletions(-) delete mode 100644 tests/xtro-sharpie/api-annotations-dotnet/MacCatalyst-AuthenticationServices.todo delete mode 100644 tests/xtro-sharpie/api-annotations-dotnet/iOS-AuthenticationServices.todo delete mode 100644 tests/xtro-sharpie/api-annotations-dotnet/macOS-AuthenticationServices.todo diff --git a/src/authenticationservices.cs b/src/authenticationservices.cs index f83d3341fbea..3b12d7c87d0e 100644 --- a/src/authenticationservices.cs +++ b/src/authenticationservices.cs @@ -745,6 +745,10 @@ public enum ASAuthorizationError : long { Failed = 1004, NotInteractive = 1005, MatchedExcludedCredential = 1006, + [NoTV] + CredentialImport = 1007, + [NoTV] + CredentialExport = 1008, } [Watch (6, 0), TV (13, 0), iOS (13, 0)] diff --git a/tests/cecil-tests/Documentation.KnownFailures.txt b/tests/cecil-tests/Documentation.KnownFailures.txt index d374cc4a9463..da8b16cb03b0 100644 --- a/tests/cecil-tests/Documentation.KnownFailures.txt +++ b/tests/cecil-tests/Documentation.KnownFailures.txt @@ -4823,6 +4823,8 @@ F:AuthenticationServices.ASAuthorizationAppleIdProviderCredentialState.Revoked F:AuthenticationServices.ASAuthorizationAppleIdProviderCredentialState.Transferred F:AuthenticationServices.ASAuthorizationControllerRequestOptions.ImmediatelyAvailableCredentials F:AuthenticationServices.ASAuthorizationError.Canceled +F:AuthenticationServices.ASAuthorizationError.CredentialExport +F:AuthenticationServices.ASAuthorizationError.CredentialImport F:AuthenticationServices.ASAuthorizationError.Failed F:AuthenticationServices.ASAuthorizationError.InvalidResponse F:AuthenticationServices.ASAuthorizationError.MatchedExcludedCredential diff --git a/tests/xtro-sharpie/api-annotations-dotnet/MacCatalyst-AuthenticationServices.todo b/tests/xtro-sharpie/api-annotations-dotnet/MacCatalyst-AuthenticationServices.todo deleted file mode 100644 index 4a8928e64b47..000000000000 --- a/tests/xtro-sharpie/api-annotations-dotnet/MacCatalyst-AuthenticationServices.todo +++ /dev/null @@ -1,2 +0,0 @@ -!missing-enum-value! ASAuthorizationError native value ASAuthorizationErrorCredentialExport = 1008 not bound -!missing-enum-value! ASAuthorizationError native value ASAuthorizationErrorCredentialImport = 1007 not bound diff --git a/tests/xtro-sharpie/api-annotations-dotnet/iOS-AuthenticationServices.todo b/tests/xtro-sharpie/api-annotations-dotnet/iOS-AuthenticationServices.todo deleted file mode 100644 index 4a8928e64b47..000000000000 --- a/tests/xtro-sharpie/api-annotations-dotnet/iOS-AuthenticationServices.todo +++ /dev/null @@ -1,2 +0,0 @@ -!missing-enum-value! ASAuthorizationError native value ASAuthorizationErrorCredentialExport = 1008 not bound -!missing-enum-value! ASAuthorizationError native value ASAuthorizationErrorCredentialImport = 1007 not bound diff --git a/tests/xtro-sharpie/api-annotations-dotnet/macOS-AuthenticationServices.todo b/tests/xtro-sharpie/api-annotations-dotnet/macOS-AuthenticationServices.todo deleted file mode 100644 index 4a8928e64b47..000000000000 --- a/tests/xtro-sharpie/api-annotations-dotnet/macOS-AuthenticationServices.todo +++ /dev/null @@ -1,2 +0,0 @@ -!missing-enum-value! ASAuthorizationError native value ASAuthorizationErrorCredentialExport = 1008 not bound -!missing-enum-value! ASAuthorizationError native value ASAuthorizationErrorCredentialImport = 1007 not bound From 95c5a37d8883b24e25319080bf972125f801cbb3 Mon Sep 17 00:00:00 2001 From: Rolf Bjarne Kvinge Date: Fri, 29 Nov 2024 10:43:35 +0100 Subject: [PATCH 2/2] Fix error enum. --- src/authenticationservices.cs | 2 -- .../api-annotations-dotnet/tvOS-AuthenticationServices.ignore | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 tests/xtro-sharpie/api-annotations-dotnet/tvOS-AuthenticationServices.ignore diff --git a/src/authenticationservices.cs b/src/authenticationservices.cs index 3b12d7c87d0e..1c548e586d14 100644 --- a/src/authenticationservices.cs +++ b/src/authenticationservices.cs @@ -745,9 +745,7 @@ public enum ASAuthorizationError : long { Failed = 1004, NotInteractive = 1005, MatchedExcludedCredential = 1006, - [NoTV] CredentialImport = 1007, - [NoTV] CredentialExport = 1008, } diff --git a/tests/xtro-sharpie/api-annotations-dotnet/tvOS-AuthenticationServices.ignore b/tests/xtro-sharpie/api-annotations-dotnet/tvOS-AuthenticationServices.ignore new file mode 100644 index 000000000000..c37382784962 --- /dev/null +++ b/tests/xtro-sharpie/api-annotations-dotnet/tvOS-AuthenticationServices.ignore @@ -0,0 +1,3 @@ +# This is an error enum, so we include all values from all platforms, even if the value doesn't exist on that platform. +!extra-enum-value! Managed value 1007 for ASAuthorizationError.CredentialImport not found in native headers +!extra-enum-value! Managed value 1008 for ASAuthorizationError.CredentialExport not found in native headers