[Localization] Use a self checkout and revert the explicit lcl paths #14843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 28, 2022 14:36
Contributor
|
I can't approve/reject this, it's too CI, so we need @mandel-macaque but I'd love a description of what and why on this PR. |
mandel-macaque
approved these changes
Apr 28, 2022
Contributor
mandel-macaque
left a comment
mandel-macaque
left a comment
There was a problem hiding this comment.
@tj-devel709 please improve the commit message as requested by @chamons
Collaborator
Collaborator
📋 [PR Build] API Diff 📋API Current PR diff✅ API Diff (from PR only) (no change) View dotnet API diffView dotnet legacy API diffAPI diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) Pipeline on Agent XAMBOT-1108.Monterey' |
Member
Author
My apologies @chamons, that was a mistake! Updated now! |
Member
Author
chamons
approved these changes
Apr 28, 2022
Collaborator
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
rolfbjarne
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my conversations with the Loc team in an issue found here: https://ceapex.visualstudio.com/CEINTL/_workitems/edit/595781
the OneLocBuild tool cannot process paths that begin with the repo name. If we checkout only one repo in Azure Devops, this is not an issue, but we were checking out multiple repos (xamarin-macios and maccore) and when we checkout more than one repo, the Build.SourceDirectory starts one level higher than the repos - hence we need to begin our paths with our repo name. This was an issue and caused OneLocBuild to point to different paths than we wanted.
This PR makes sure that we only checkout xamarin-macios in the localization job and makes the appropriate changes changing the paths. We also need to revert a PR: #14811, which updated all the lcl paths manually since we are changing the paths back to default.