Build against Cecil submodule (#1477)

* Build against Cecil submodule

* Depend on official cecil version

With this change, the nuspec of the ref assembly package will
list cecil verision 0.11.2 as a dependency (instead of 5.0.0-rc*).
This allows consumers of the ref package to use the publicly
released cecil.

Author: sbomer

Directory.Build.props

@@ -25,9 +25,8 @@
     <IsPackable>false</IsPackable>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <_ToolsProjectTargets>$(ArtifactsToolsetDir)Common\Tools.proj.nuget.g.targets</_ToolsProjectTargets>
-    <!-- Set this to false to build against the submodule. Convenient for experimenting locally. -->
-    <UseCecilPackage Condition="'$(MonoBuild)' != '' And '$(UseCecilPackage)' == ''">false</UseCecilPackage>
-    <UseCecilPackage Condition="'$(UseCecilPackage)' == ''">true</UseCecilPackage>
+    <!-- Set this to true to build against the package instead of the submodule. -->
+    <UseCecilPackage Condition="'$(UseCecilPackage)' == ''">false</UseCecilPackage>
     <!-- No symbols are produced for ref assemblies, but some parts of the SDK still expect pdbs, so we explicitly tell it there are none. -->
     <!-- Must be set after importing Arcade to override its defaults. -->
     <DebugType Condition=" '$(IsReferenceAssembly)' == 'true' ">none</DebugType>

eng/Versions.props

@@ -22,7 +22,9 @@
     <MicrosoftBuildUtilitiesCoreVersion>15.4.8</MicrosoftBuildUtilitiesCoreVersion>
     <MicrosoftDotNetApiCompatVersion>5.0.0-beta.20506.7</MicrosoftDotNetApiCompatVersion>
     <MicrosoftDotNetCodeAnalysisVersion>5.0.0-beta.20471.1</MicrosoftDotNetCodeAnalysisVersion>
-    <!-- We depend on (and redistribute) the official Mono.Cecil NuGet package built from https://github.com/jbevain/cecil -->
+    <!-- This controls the version of the cecil package, or the version of cecil in the project graph
+         when we build the cecil submodule. The reference assembly package will depend on this version of cecil.
+         Keep this in sync with ProjectInfo.cs in the submodule. -->
     <MonoCecilVersion>0.11.3</MonoCecilVersion>
     <UseVSTestRunner>true</UseVSTestRunner>
   </PropertyGroup>

external/Mono.Cecil.overrides

@@ -8,6 +8,11 @@
     <!-- Cecil sets PublicSign on windows, but we always want to
          PublicSign. -->
     <PublicSign>true</PublicSign>
+    <!-- When we build the cecil submodule, use the same version number
+         as the package dependency. This way the linker ref assembly package
+         will depend on the publicly available package. Note that we can't set
+         just set Version here because Arcade will override it. -->
+    <PackageVersion>$(MonoCecilVersion)</PackageVersion>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(MonoBuild)' == ''">