[Java.Interop] restore IL2035 suppression (#1195)

jonathanpeppers · web-flow · commit ae6560976d7a · 2024-02-20T14:13:30.000-05:00
c6e3893 introduced build warning(s) in Android projects: external/Java.Interop/src/Java.Interop/Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs(33,4): warning IL2035: Java.Interop.JniRuntime.SetMarshalMemberBuilder(JniRuntime.CreationOptions): Unresolved assembly 'Java.Interop.Export' in 'DynamicDependencyAttribute'. external/Java.Interop/src/Java.Interop/Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs(33,4): warning IL2035: Java.Interop.JniRuntime.SetMarshalMemberBuilder(JniRuntime.CreationOptions): Unresolved assembly 'Java.Interop.Export' in 'DynamicDependencyAttribute'. external/Java.Interop/src/Java.Interop/Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs(33,4): warning IL2035: Java.Interop.JniRuntime.SetMarshalMemberBuilder(JniRuntime.CreationOptions): Unresolved assembly 'Java.Interop.Export' in 'DynamicDependencyAttribute'. external/Java.Interop/src/Java.Interop/Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs(33,4): warning IL2035: Java.Interop.JniRuntime.SetMarshalMemberBuilder(JniRuntime.CreationOptions): Unresolved assembly 'Java.Interop.Export' in 'DynamicDependencyAttribute'. One of these appear per-RID. Partially revert c6e3893 to restore the IL2035 suppression that was removed.
diff --git a/src/Java.Interop/Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs b/src/Java.Interop/Java.Interop/JniRuntime.JniMarshalMemberBuilder.cs
@@ -28,6 +28,7 @@ public  JniMarshalMemberBuilder        MarshalMemberBuilder        {
 		}
 
 		[DynamicDependency (DynamicallyAccessedMemberTypes.PublicParameterlessConstructor, "Java.Interop.MarshalMemberBuilder", "Java.Interop.Export")]
+		[UnconditionalSuppressMessage ("Trimming", "IL2035", Justification = "Java.Interop.Export.dll is not always present.")]
 		partial void SetMarshalMemberBuilder (CreationOptions options)
 		{
 			if (!options.UseMarshalMemberBuilder) {

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ public JniMarshalMemberBuilder MarshalMemberBuilder {`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`[DynamicDependency (DynamicallyAccessedMemberTypes.PublicParameterlessConstructor, "Java.Interop.MarshalMemberBuilder", "Java.Interop.Export")]`
	`31`	`+ [UnconditionalSuppressMessage ("Trimming", "IL2035", Justification = "Java.Interop.Export.dll is not always present.")]`
`31`	`32`	`partial void SetMarshalMemberBuilder (CreationOptions options)`
`32`	`33`	`{`
`33`	`34`	`if (!options.UseMarshalMemberBuilder) {`