Commit 651de42
authored
[Java.Interop] supress one instance of IL2072 (#1205)
Context: dotnet/android#8805
When testing new defaults for `$(TrimMode)=full` in
dotnet/android#8805:
% dotnet new android
% dotnet build -c Release -r android-arm64
Results in a single warning:
external\Java.Interop\src\Java.Interop\Java.Interop\JniRuntime.JniValueManager.cs(890,4):
Trim analysis warning IL2072: Java.Interop.ProxyValueMarshaler.CreateGenericObjectReferenceArgumentState(Object, ParameterAttributes):
'type' argument does not satisfy 'DynamicallyAccessedMemberTypes.Interfaces' in call to 'Java.Interop.JniRuntime.JniValueManager.GetValueMarshaler(Type)'.
The return value of method 'System.Object.GetType()' does not have matching annotations.
The source value must declare at least the same requirements as those declared on the target location it is assigned to.
This appears to be a case where the trimmer (ILLink's analyzers) can
detect a problem where the Roslyn analyzer could not. It is generally
possible for the trimmer to discover some new warning, as it has a
complete view of the final code.
This appears to be similar to some other places we used the justification:
[UnconditionalSuppressMessage ("Trimming", "IL2073", Justification = "This code path is not used in Android projects.")]1 parent 5bca8ad commit 651de42
1 file changed
+5
-1
lines changedLines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
884 | 884 | | |
885 | 885 | | |
886 | 886 | | |
| 887 | + | |
| 888 | + | |
| 889 | + | |
| 890 | + | |
887 | 891 | | |
888 | 892 | | |
889 | 893 | | |
890 | 894 | | |
891 | 895 | | |
892 | | - | |
| 896 | + | |
893 | 897 | | |
894 | 898 | | |
895 | 899 | | |
| |||
0 commit comments