Pin OmniSharp version used for testing #17074
Conversation
| public class OmniSharpTests : SmokeTests | ||
| { | ||
| // Update version as new releases become available: https://github.com/OmniSharp/omnisharp-roslyn/releases | ||
| private const string OmniSharpReleaseVersion = "1.39.8"; |
There was a problem hiding this comment.
Is there anyway we could utilize dependabot to update this for us?
There was a problem hiding this comment.
Dependabot doesn't support git/GitHub as a source. But apparently Renovate does.
There was a problem hiding this comment.
Yes. I know Omnisharp also publishes NuGet packages. As a workaround, I thought maybe we could add a package reference and grab it's version from the test. Renovate would work too if we are allowed to use it.
There was a problem hiding this comment.
Interestingly, their NuGet packages are behind from their actual releases by two versions.
There was a problem hiding this comment.
Well that's unfortunate. If the low solutions have been exhausted, perhaps we should log a follow-up to automate this. In the meantime would it make sense to add a step to the release checklist?
There was a problem hiding this comment.
Sure, I'll log a follow-up issue to automate. I can update the release checklist but that's a different repo.
3 participants
This helps protected the smoke tests from unexpected changes to OmniSharp that may cause the test to break. It pins the version of OmniSharp that is downloaded to use a specific version. This will need to be manually updated as new releases become available.
Also removed a redundant command to set the permissions of the OmniSharp
runscript. This was mistakenly merged in from servicing branches.Fixes dotnet/source-build#3536