Fix a copypaste checking bug in unpickling #18430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
❗ Release notes required
|
psfinaki
changed the title
T-Gro
approved these changes
Apr 7, 2025
KevinRansom
approved these changes
Apr 8, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
T-Gro
added a commit
that referenced
this pull request
Apr 8, 2025
* Fix a copypaste checking bug in unpickling (#18430) * Tooltips: fix `null` annotation highlighting (#18457) * Tooltips: fix `null` annotation highlighting * Release notes --------- Co-authored-by: Petr <[email protected]> Co-authored-by: Eugene Auduchinok <[email protected]>
This was referenced May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 4 node in tables used in unpickling: entities, anon infos, vals and typars.
It's very likely there was a copypaste bug in checking the tables.