Skip to content

Conversation

@KevinRansom
Copy link
Contributor

@KevinRansom KevinRansom commented Feb 6, 2024

Fixes #16572

The union case enable Is* properties in F# has a bug.

The bug shows up when using recursive namespace and module in combination with union cases and sig files. The current implementation fails to make the get_IsBlahBlah method available when a sig file is present.

This PR fixes the issue by:

  • Ensuring the added val is incorporated in the sigfile.
  • Adds a test to cover the failing scenario.
  • Fixes a test which fails when the using case feature is enabled, by restricting the lang version to 8 for that test case.
  • Adding a new smoke test case for the feature with lang version set to preview.
  • The discriminated union test cases were run on netcoreapp builds only, so i added them to desktop builds for completeness.

@KevinRansom KevinRansom requested a review from a team as a code owner February 6, 2024 13:58
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

@psfinaki
Copy link
Contributor

psfinaki commented Feb 6, 2024

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Member

@T-Gro T-Gro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval based on changes needed in the RFC to document the changed behavior with .fsi files.

@psfinaki psfinaki merged commit f6f49b6 into dotnet:main Feb 12, 2024
@KevinRansom KevinRansom deleted the fix16572 branch March 21, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Enabling preview features causes an issue with main somehow.

4 participants