Project Generation improvements #15615
Conversation
| this.Workflow.Checker | ||
| this.Workflow.Checker | ||
|
|
||
| static member CreateFromRealProject(projectDir) = |
There was a problem hiding this comment.
Where is this being exercised? Is CI capable of running this?
There was a problem hiding this comment.
Nowhere in main so far. CI should be capable of using this if we provide a local copy of some project (not sure if it can handle anything we have in the repo).
There was a problem hiding this comment.
I think this folder ~\tests\projects\stress or its parent should have eligible projects.
|
|
||
| static member CreateFromRealProject(projectDir) = | ||
|
|
||
| let projectFile = |
There was a problem hiding this comment.
I was somewhat expecting to use to codepath which we already have for converting command line options into project options going into the checker.
i.e. by invoking a design time build, which would do all the msbuild magic, and end up with a list of fsc.exe CLI arguments.
As a benefit, that codepath would then be also tested by it.
There was a problem hiding this comment.
I think this is something @vzarytovskii wants to try to do. Should be doable but might have some other challenges.
There was a problem hiding this comment.
The downside is invoking msbuild to do an actual design time build, but I do not think that matters for benchmarking/testing, as this is a one time setup per project, can be cached.
I see a very big advantage in exercising code we already use in editor, and of course supporting a lot more different CLI options (translated from .fsbuild props) as well as configuration sources ;; most notable Directory.Build.props.
==> all without us having to implement the nitty details of it.
3 participants
Adding ProjectGeneration improvements that came out of TransparentCompiler testing and benchmarking. Most notably the ability to load a (simple) project (like Giraffe) to run tests and benchmarks on using FCS.