.NET 9preview5 (#17224)

* .NET 9preview4

* New macos + udpated prebuilts

* p5 + some tests fixes

* Update SourceBuildPrebuiltBaseline.xml

* fix

* Don't use msbuild output

* Update OperatorsModuleDynamic.fs

* reverting this, will be fixed separately

* up

* Update OperatorsModuleDynamic.fs

* Revert "Update OperatorsModuleDynamic.fs"

This reverts commit fc20f9e.

* Update OperatorsModuleDynamic.fs

* Update OperatorsModuleDynamic.fs

* up

* Update OperatorsModule1.fs

* Update OperatorsModule2.fs

* Update OperatorsModuleDynamic.fs

* Update OperatorsModule1.fs

* Update OperatorsModule2.fs

* Update OperatorsModule2.fs

* remove old workarond

* Revert "remove old workarond"

This reverts commit a27df0f.

* Update OperatorsModule2.fs

* invert ifs, set up consts

* comments

---------

Co-authored-by: Petr <[email protected]>

Author: vzarytovskii

.devcontainer/devcontainer.json

@@ -1,12 +1,12 @@
 // For format details, see https://aka.ms/vscode-remote/devcontainer.json or this file's README at:
 {
     "name": "F#",
-    "image": "mcr.microsoft.com/dotnet/sdk:9.0.100-preview.3",
+    "image": "mcr.microsoft.com/dotnet/sdk:9.0.100-preview.5",
     "features": {
-        "ghcr.io/devcontainers/features/common-utils:2.4.2": {},
+        "ghcr.io/devcontainers/features/common-utils:2.4.3": {},
         "ghcr.io/devcontainers/features/git:1.2.0": {},
         "ghcr.io/devcontainers/features/github-cli:1.0.11": {},
-        "ghcr.io/devcontainers/features/dotnet:2.0.5": {}
+        "ghcr.io/devcontainers/features/dotnet:2.1.0": {}
     },
     "hostRequirements": {
         "cpus": 2,

eng/Build.ps1

@@ -361,7 +361,7 @@ function TestUsingMSBuild([string] $testProject, [string] $targetFramework, [str
     $testLogPath = "$ArtifactsDir\TestResults\$configuration\${projectName}_$targetFramework.xml"
     $testBinLogPath = "$LogDir\${projectName}_$targetFramework.binlog"
     $args = "test $testProject -c $configuration -f $targetFramework -v n --test-adapter-path $testadapterpath --logger ""nunit;LogFilePath=$testLogPath"" /bl:$testBinLogPath"
-    $args += " --blame --results-directory $ArtifactsDir\TestResults\$configuration"
+    $args += " --blame --results-directory $ArtifactsDir\TestResults\$configuration -p:vstestusemsbuildoutput=false"
 
     if (-not $noVisualStudio -or $norestore) {
         $args += " --no-restore"

eng/SourceBuildPrebuiltBaseline.xml

@@ -9,16 +9,16 @@
       These will go away when repo updates targeting to net8.0
       Tracked with https://github.com/dotnet/fsharp/issues/14765
     -->
-    <UsagePattern IdentityGlob="Microsoft.AspNetCore.App.Ref/8.0.2" />
-    <UsagePattern IdentityGlob="Microsoft.NETCore.App.Host.linux-x64/8.0.2" />
-    <UsagePattern IdentityGlob="Microsoft.NETCore.App.Ref/8.0.2" />
+    <UsagePattern IdentityGlob="Microsoft.AspNetCore.App.Ref/8.0.*" />
+    <UsagePattern IdentityGlob="Microsoft.NETCore.App.Host.linux-x64/8.0.*" />
+    <UsagePattern IdentityGlob="Microsoft.NETCore.App.Ref/8.0.*" />
     <UsagePattern IdentityGlob="System.Configuration.ConfigurationManager/7.0.0" />
     <UsagePattern IdentityGlob="System.Diagnostics.EventLog/7.0.0" />
     <UsagePattern IdentityGlob="System.Security.Cryptography.ProtectedData/7.0.0" />
 
-    <UsagePattern IdentityGlob="Microsoft.AspNetCore.App.Runtime.linux-x64/8.0.2" />
-    <UsagePattern IdentityGlob="Microsoft.NETCore.App.Crossgen2.linux-x64/8.0.2" />
-    <UsagePattern IdentityGlob="Microsoft.NETCore.App.Runtime.linux-x64/8.0.2" />
+    <UsagePattern IdentityGlob="Microsoft.AspNetCore.App.Runtime.linux-x64/8.0.*" />
+    <UsagePattern IdentityGlob="Microsoft.NETCore.App.Crossgen2.linux-x64/8.0.*" />
+    <UsagePattern IdentityGlob="Microsoft.NETCore.App.Runtime.linux-x64/8.0.*" />
 
 
     <!-- Tracked in https://github.com/dotnet/source-build/issues/3438 -->

eng/build.sh

@@ -214,7 +214,7 @@ function Test() {
   projectname=$(basename -- "$testproject")
   projectname="${projectname%.*}"
   testlogpath="$artifacts_dir/TestResults/$configuration/${projectname}_$targetframework.xml"
-  args="test \"$testproject\" --no-restore --no-build -c $configuration -f $targetframework --test-adapter-path . --logger \"nunit;LogFilePath=$testlogpath\" --blame --results-directory $artifacts_dir/TestResults/$configuration"
+  args="test \"$testproject\" --no-restore --no-build -c $configuration -f $targetframework --test-adapter-path . --logger \"nunit;LogFilePath=$testlogpath\" --blame --results-directory $artifacts_dir/TestResults/$configuration -p:vstestusemsbuildoutput=false"
   "$DOTNET_INSTALL_DIR/dotnet" $args || exit $?
 }
 

global.json

@@ -1,10 +1,10 @@
 {
   "sdk": {
-    "version": "9.0.100-preview.3.24204.13",
+    "version": "9.0.100-preview.5.24307.3",
     "allowPrerelease": true
   },
   "tools": {
-    "dotnet": "9.0.100-preview.3.24204.13",
+    "dotnet": "9.0.100-preview.5.24307.3",
     "vs": {
       "version": "17.8",
       "components": [

tests/FSharp.Core.UnitTests/FSharp.Core/OperatorsModule1.fs

@@ -3,6 +3,10 @@
 // Various tests for the:
 // Microsoft.FSharp.Core.Operators module
 
+// For information on the runtime-dependent behavior differences in this file, see:
+// - https://github.com/dotnet/runtime/issues/61885
+// - https://github.com/dotnet/runtime/pull/97529
+
 namespace FSharp.Core.UnitTests.Operators
 
 open System
@@ -278,18 +282,24 @@ type OperatorsModule1() =
         // Overflow
         let result = Operators.byte Single.MinValue
         Assert.AreEqual(0uy, result)
-        
+
         // Overflow
         let result = Operators.byte Single.MaxValue
-        Assert.AreEqual(0uy, result)
-        
+        if Info.isNetFramework then
+            Assert.AreEqual(0uy, result)
+        else
+            Assert.AreEqual(255uy, result)
+
         // Overflow
         let result = Operators.byte Double.MinValue
         Assert.AreEqual(0uy, result)
-        
+
         // Overflow
         let result = Operators.byte Double.MaxValue
-        Assert.AreEqual(0uy, result)
+        if Info.isNetFramework then
+            Assert.AreEqual(0uy, result)
+        else
+            Assert.AreEqual(255uy, result)
 
         // Overflow
         let result = Operators.byte (Int64.MaxValue * 8L)
@@ -343,9 +353,15 @@ type OperatorsModule1() =
 
         // Overflow
         Assert.AreEqual('\000', Operators.char Single.MinValue)
-        Assert.AreEqual('\000', Operators.char Double.MinValue)
-        Assert.AreEqual('\000', Operators.char Single.MaxValue)
-        Assert.AreEqual('\000', Operators.char Double.MaxValue)
+        if Info.isNetFramework then
+            Assert.AreEqual('\000', Operators.char Single.MaxValue)
+        else
+            Assert.AreEqual('\uffff', Operators.char Single.MaxValue)
+
+        if Info.isNetFramework then
+            Assert.AreEqual('\000', Operators.char Double.MaxValue)
+        else
+            Assert.AreEqual('\uffff', Operators.char Double.MaxValue)
         CheckThrowsOverflowException(fun () -> Operators.char Decimal.MinValue |> ignore)
 
         // string type