Expose building blocks for external service discovery implementations #6946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart-vmware
force-pushed
the
service-discovery-apis
branch
from
bf2d2f6 to
8ce3522
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR exposes building blocks for external service discovery implementations by making previously internal APIs public. The changes enable external developers to implement custom service discovery providers while maintaining consistency with internal patterns.
Key changes:
- Made
UriEndPointclass public with proper constructor and null validation - Exposed
ApplyAllowedSchemesas a public instance method onServiceDiscoveryOptions - Added
ServiceEndpoint.TryParsestatic method to provide a standard way to parse endpoint strings
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ServiceDiscoveryOptions.cs | Changed ApplyAllowedSchemes from internal static to public instance method with XML documentation |
| ConfigurationServiceEndpointProvider.cs | Updated to use new public ApplyAllowedSchemes method and consolidated endpoint parsing logic |
| UriEndPoint.cs | Changed from internal sealed to public class with public constructor and null validation |
| ServiceEndpoint.cs | Added public TryParse method to centralize endpoint string parsing logic |
src/Libraries/Microsoft.Extensions.ServiceDiscovery.Abstractions/ServiceEndpoint.cs
Show resolved
Hide resolved
.../Microsoft.Extensions.ServiceDiscovery/Configuration/ConfigurationServiceEndpointProvider.cs
Show resolved
Hide resolved
Contributor
Author
|
@ReubenBond, can you please review this PR? |
ReubenBond
approved these changes
Oct 22, 2025
bart-vmware
force-pushed
the
service-discovery-apis
branch
from
a5b1712 to
2fe85ad
Compare
Contributor
Author
|
@ReubenBond Thanks for the review and approval. |
bart-vmware
force-pushed
the
service-discovery-apis
branch
from
2fe85ad to
598e76f
Compare
…or nullability in netstandard/netfx
bart-vmware
force-pushed
the
service-discovery-apis
branch
from
598e76f to
1e5dc94
Compare
davidfowl
approved these changes
Oct 28, 2025
Contributor
Author
|
@rzikm Can you please merge this? I'm trying to find someone with merge permissions... |
This was referenced Nov 11, 2025
Merged
Merged
This was referenced Nov 13, 2025
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #dotnet/aspire#4224.
Microsoft Reviewers: Open in CodeFlow