Allow shared columns with nullable value converters #29746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
Issue29531
branch
from
d9b2021 to
4713eb7
Compare
AndriySvyryd
force-pushed
the
Issue29531
branch
from
4713eb7 to
943932e
Compare
Make IColumn.ProviderClrType always non-nullable for value types Fixes #29531
AndriySvyryd
force-pushed
the
Issue29531
branch
from
943932e to
ba6ed8f
Compare
ajcvickers
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
IColumn.ProviderClrTypealways non-nullable for value typesFixes #29531