Fix SQL Server bulk insert edge case #29669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Nov 30, 2022
roji
added a commit
to roji/efcore
that referenced
this pull request
Nov 30, 2022
Fixes dotnet#29539 (cherry picked from commit 851e47f)
This was referenced Nov 30, 2022
wtgodbe
pushed a commit
that referenced
this pull request
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the application of pending bulk commands to before we snapshot the SQL position, result set count, etc. This way, if the new command goes beyond the parameter limit and causes a rollback, we don't lose the pending bulk commands.
Fixes #29539