This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add initial nullability annotations guidance #36711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
approved these changes
Apr 8, 2019
terrajobst
approved these changes
Apr 9, 2019
stephentoub
force-pushed
the
nulldocs
branch
2 times, most recently
from
e2ac952 to
9c34246
Compare
Member
Author
|
Thanks for the very helpful feedback. I addressed all of it. |
ahsonkhan
reviewed
Apr 9, 2019
ahsonkhan
reviewed
Apr 9, 2019
ahsonkhan
reviewed
Apr 9, 2019
|
I had this PR open from last night. I didn't realize it was already merged. The feedback can be ignored, since it was mainly nits/re-word to make it easier to read. |
safern
reviewed
Apr 9, 2019
Member
safern
left a comment
safern
left a comment
There was a problem hiding this comment.
This is awesome, thanks for putting it all together 😄
Member
Author
|
Thanks, @ahsonkhan. I addressed your feedback. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Add initial nullability annotations guidance * Address PR feedback Commit migrated from dotnet/corefx@663af00
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @dotnet/nullablefc, @bartonjs, @MadsTorgersen, @jaredpar