Redirect to homepage if login page is requested when token auth is not enabled #5123
+120
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamint
requested review from
JamesNK,
danmoseley,
drewnoakes,
eerhardt and
tlmii
ghost
added
the
JamesNK
requested changes
Jul 30, 2024
Member
JamesNK
left a comment
JamesNK
left a comment
There was a problem hiding this comment.
Test please. Can either be an integration test or you could test the middleware on its own.
dotnet-policy-service
bot
added
the
needs-author-action
Member
Author
Tested middleware in isolation |
dotnet-policy-service
bot
removed
the
needs-author-action
JamesNK
reviewed
Aug 1, 2024
tests/Aspire.Dashboard.Tests/Middleware/ValidateTokenMiddlewareTests.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Open
3 tasks
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JamesNK
reviewed
Aug 2, 2024
JamesNK
approved these changes
Aug 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looping in a wider range of reviewers because this is modifying a sensitive code path. Fixes #3775 by redirecting if the requested path equals
/loginand auth mode is nottoken, including when the token query parameter (t) is not included in the URL.demo, token auth NOT enabled:
Screen.Recording.2024-07-30.at.3.30.58.PM.mov
demo, token auth enabled (login page still shows and works as normal)
Screen.Recording.2024-07-30.at.3.35.34.PM.mov
Microsoft Reviewers: Open in CodeFlow