Skip to content

Commit b834d50

Browse files
committed
Review feedback
1 parent bd3df2a commit b834d50

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

src/Aspire.Hosting/Dashboard/proto/resource_service.proto

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ syntax = "proto3";
55

66
package aspire.v1;
77

8+
import "google/protobuf/struct.proto";
89
import "google/protobuf/timestamp.proto";
910

1011
////////////////////////////////////////////
@@ -22,14 +23,20 @@ message ApplicationInformationResponse {
2223
message ResourceCommandRequest {
2324
string command_type = 1;
2425
ResourceId resource_id = 2;
26+
// When present, this message must be shown to the user and their confirmation obtained
27+
// before sending the request for this command to be executed.
2528
optional string confirmation_message = 3;
29+
// Optional parameter that configures the command in some way.
30+
// Clients must return any value provided by the server when invoking
31+
// the command.
32+
optional google.protobuf.Value parameter = 4;
2633
}
2734

2835
enum ResourceCommandResponseKind {
29-
none = 0;
30-
succeeded = 1;
31-
failed = 2;
32-
cancelled = 3;
36+
UNDEFINED = 0;
37+
SUCCEEDED = 1;
38+
FAILED = 2;
39+
CANCELLED = 3;
3340
}
3441

3542
message ResourceCommandResponse {
@@ -84,11 +91,8 @@ message AdditionalData {
8491
optional string namespace = 2;
8592
// Optional display name, may be localized
8693
optional string display_name = 3;
87-
// A single value will be most common. Also support lists, to avoid escaping.
88-
oneof kind {
89-
string value = 4;
90-
StringArray values = 5;
91-
}
94+
// The data value. May be null, a number, a string, a boolean, a dictionary of values (Struct), or a list of values (ValueList).
95+
google.protobuf.Value value = 4;
9296
}
9397

9498
message ResourceId {

0 commit comments

Comments
 (0)