bump Microsoft.CodeAnalysis to latest (#13699)

* bump Microsoft.CodeAnalysis to latest

* Change CodeAnalysis version to 4.6.0

* baseline Microsoft.CodeAnalysis

* Update Versions.props

---------

Co-authored-by: Viktor Hofer <[email protected]>

Author: oleksandr-didyk

eng/SourceBuildPrebuiltBaseline.xml

@@ -5,5 +5,14 @@
     <!-- TODO: Ignore needed until https://github.com/NuGet/Home/issues/11059 is addressed. -->
     <UsagePattern IdentityGlob="Nuget.*/*" />
 
+    <!-- GenFacades needs to load this in during the build, restricting SBRP usage. Moreover,
+      latest version cannot be referenced as this dependency sets the minimum version that is
+      required to be present inbox in the SDK and Roslyn VS. For more information see
+      https://github.com/dotnet/arcade/pull/13699#discussion_r1205752883. 
+        
+      In the product build a version from previosly-source-build artifacts is utilized thanks
+      to the corresponding entry in Version.Details.xml -->
+    <UsagePattern IdentityGlob="Microsoft.CodeAnalysis.*/*" />
+
   </IgnorePatterns>
 </UsageData>

eng/Version.Details.xml

@@ -3,6 +3,10 @@
   <ProductDependencies>
   </ProductDependencies>
   <ToolsetDependencies>
+    <Dependency Name="Microsoft.CodeAnalysis.CSharp" Version="4.6.0">
+      <Uri>https://github.com/dotnet/roslyn</Uri>
+      <Sha>c3cc1d0ceeab1a65da0217e403851a1e8a30086a</Sha>
+    </Dependency>
     <Dependency Name="Microsoft.SymbolUploader.Build.Task" Version="2.0.0-preview.1.21526.15">
       <Uri>https://dev.azure.com/dnceng/internal/_git/dotnet-symuploader</Uri>
       <Sha>62ceb439e80bf0814d0ffa17f022d4624ea4aa6c</Sha>

eng/Versions.props

@@ -39,8 +39,8 @@
     <NuGetProjectModelVersion>6.2.2</NuGetProjectModelVersion>
     <NuGetVersioningVersion>6.2.2</NuGetVersioningVersion>
     <!-- roslyn -->
-    <MicrosoftCodeAnalysisCSharpVersion>4.4.0</MicrosoftCodeAnalysisCSharpVersion>
-    <MicrosoftNetCompilersToolsetVersion>4.5.2-3.23266.1</MicrosoftNetCompilersToolsetVersion>
+    <MicrosoftCodeAnalysisCSharpVersion>4.6.0</MicrosoftCodeAnalysisCSharpVersion>
+    <MicrosoftNetCompilersToolsetVersion>4.6.0</MicrosoftNetCompilersToolsetVersion>
     <!-- runtime -->
     <MicrosoftExtensionsDependencyInjectionAbstractionsVersion>6.0.0</MicrosoftExtensionsDependencyInjectionAbstractionsVersion>
     <MicrosoftExtensionsDependencyInjectionVersion>6.0.0</MicrosoftExtensionsDependencyInjectionVersion>

src/Microsoft.DotNet.CodeAnalysis/Analyzers/MembersMustExistAnalyzer.cs

@@ -23,7 +23,7 @@ public class MembersMustExistAnalyzer : BaseAnalyzer
         private HashSet<string> _apisToEnsureExist = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
 
         private static readonly DiagnosticDescriptor s_memberMustExistDiagnostic =
-            new DiagnosticDescriptor(DiagnosticIds.BCL0001.ToString(), s_title, s_messageFormat, s_analyzerName, DiagnosticSeverity.Error, isEnabledByDefault: true, description: s_description);
+            new DiagnosticDescriptor(DiagnosticIds.BCL0001.ToString(), s_title, s_messageFormat, s_analyzerName, DiagnosticSeverity.Error, isEnabledByDefault: true, description: s_description, customTags: WellKnownDiagnosticTags.CompilationEnd);
 
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get { return ImmutableArray.Create(s_memberMustExistDiagnostic); } }
 

src/Microsoft.DotNet.CodeAnalysis/Microsoft.DotNet.CodeAnalysis.csproj

@@ -4,6 +4,7 @@
     <TargetFramework>netstandard2.0</TargetFramework>
     <IncludeBuildOutput>false</IncludeBuildOutput>
     <IsPackable>true</IsPackable>
+    <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
     <CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)CodeAnalysis.ruleset</CodeAnalysisRuleSet>
     <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking>
     <TargetsForTfmSpecificContentInPackage>$(TargetsForTfmSpecificContentInPackage);_AddAnalyzerToOutput</TargetsForTfmSpecificContentInPackage>