[tests] fix AndroidUpdateResourcesTest.Issue2205 on Windows (#2281)

Context: http://build.devdiv.io/2098745

The `AndroidUpdateResourcesTest.Issue2205()` test is failing on
Windows with:

	Error message
	  System.ArgumentException : Illegal characters in path.
	Stack trace
	  at System.IO.Path.CheckInvalidPathChars(String path, Boolean checkAdditional)
	  at System.IO.Path.Combine(String path1, String path2)
	  at Xamarin.ProjectTools.XamarinProject.UpdateProjectFiles(String directory, IEnumerable`1 projectFiles, Boolean doNotCleanup)
	  at Xamarin.ProjectTools.XamarinProject.Populate(String directory, IEnumerable`1 projectFiles)
	  at Xamarin.ProjectTools.ProjectBuilder.Save(XamarinProject project, Boolean doNotCleanupOnUpdate, Boolean saveProject)
	  at Xamarin.ProjectTools.ProjectBuilder.Build(XamarinProject project, Boolean doNotCleanupOnUpdate, String[] parameters, Boolean saveProject, Dictionary`2 environmentVariables)
	  at Xamarin.Android.Build.Tests.AndroidUpdateResourcesTest.Issue2205(Boolean useAapt2)

Looking at the test, the `@(GoogleServicesJson)` build item was
declaring JSON string contents as a filename.  Whoops!

I guess that macOS was OK with a JSON filename, as the JSON contents
didn't contain a `/`, while Windows was certainly not, as the JSON
string contained `:`.

I changed the `BuildItem` to use the `TextContent` property, and used
a filename of `googleservices.json`. I also let VS format the method,
so it matches our code formatting standards.

Author: jonathanpeppers

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AndroidUpdateResourcesTest.cs

@@ -1412,30 +1412,31 @@ public void CustomViewAddResourceId ([Values (false, true)] bool useAapt2)
 
 		// https://github.com/xamarin/xamarin-android/issues/2205
 		[Test]
-		public void Issue2205 ([Values(false, true)] bool useAapt2)
+		public void Issue2205 ([Values (false, true)] bool useAapt2)
 		{
-			var proj = new XamarinAndroidApplicationProject();
-			proj.SetProperty("AndroidUseAapt2", useAapt2.ToString());
-			proj.Packages.Add(KnownPackages.Android_Arch_Core_Common_26_1_0);
-			proj.Packages.Add(KnownPackages.Android_Arch_Lifecycle_Common_26_1_0);
-			proj.Packages.Add(KnownPackages.Android_Arch_Lifecycle_Runtime_26_1_0);
-			proj.Packages.Add(KnownPackages.AndroidSupportV4_27_0_2_1);
-			proj.Packages.Add(KnownPackages.SupportCompat_27_0_2_1);
-			proj.Packages.Add(KnownPackages.SupportCoreUI_27_0_2_1);
-			proj.Packages.Add(KnownPackages.SupportCoreUtils_27_0_2_1);
-			proj.Packages.Add(KnownPackages.SupportDesign_27_0_2_1);
-			proj.Packages.Add(KnownPackages.SupportFragment_27_0_2_1);
-			proj.Packages.Add(KnownPackages.SupportMediaCompat_27_0_2_1);
-			proj.Packages.Add(KnownPackages.SupportV7AppCompat_27_0_2_1);
-			proj.Packages.Add(KnownPackages.SupportV7CardView_27_0_2_1);
-			proj.Packages.Add(KnownPackages.SupportV7MediaRouter_27_0_2_1);
-			proj.Packages.Add(KnownPackages.SupportV7RecyclerView_27_0_2_1);
-			proj.Packages.Add(KnownPackages.Xamarin_GooglePlayServices_Gcm);
-			proj.Packages.Add(KnownPackages.Xamarin_GooglePlayServices_Tasks);
-			proj.Packages.Add(KnownPackages.Xamarin_GooglePlayServices_Iid);
-			proj.Packages.Add(KnownPackages.Xamarin_GooglePlayServices_Basement);
-			proj.Packages.Add(KnownPackages.Xamarin_GooglePlayServices_Base);
-			proj.OtherBuildItems.Add(new BuildItem("GoogleServicesJson", () => @"{
+			var proj = new XamarinAndroidApplicationProject ();
+			proj.SetProperty ("AndroidUseAapt2", useAapt2.ToString ());
+			proj.Packages.Add (KnownPackages.Android_Arch_Core_Common_26_1_0);
+			proj.Packages.Add (KnownPackages.Android_Arch_Lifecycle_Common_26_1_0);
+			proj.Packages.Add (KnownPackages.Android_Arch_Lifecycle_Runtime_26_1_0);
+			proj.Packages.Add (KnownPackages.AndroidSupportV4_27_0_2_1);
+			proj.Packages.Add (KnownPackages.SupportCompat_27_0_2_1);
+			proj.Packages.Add (KnownPackages.SupportCoreUI_27_0_2_1);
+			proj.Packages.Add (KnownPackages.SupportCoreUtils_27_0_2_1);
+			proj.Packages.Add (KnownPackages.SupportDesign_27_0_2_1);
+			proj.Packages.Add (KnownPackages.SupportFragment_27_0_2_1);
+			proj.Packages.Add (KnownPackages.SupportMediaCompat_27_0_2_1);
+			proj.Packages.Add (KnownPackages.SupportV7AppCompat_27_0_2_1);
+			proj.Packages.Add (KnownPackages.SupportV7CardView_27_0_2_1);
+			proj.Packages.Add (KnownPackages.SupportV7MediaRouter_27_0_2_1);
+			proj.Packages.Add (KnownPackages.SupportV7RecyclerView_27_0_2_1);
+			proj.Packages.Add (KnownPackages.Xamarin_GooglePlayServices_Gcm);
+			proj.Packages.Add (KnownPackages.Xamarin_GooglePlayServices_Tasks);
+			proj.Packages.Add (KnownPackages.Xamarin_GooglePlayServices_Iid);
+			proj.Packages.Add (KnownPackages.Xamarin_GooglePlayServices_Basement);
+			proj.Packages.Add (KnownPackages.Xamarin_GooglePlayServices_Base);
+			proj.OtherBuildItems.Add (new BuildItem ("GoogleServicesJson", "googleservices.json") {
+				TextContent = () => @"{
     ""project_info"": {
         ""project_number"": ""12351255213413432"",
         ""project_id"": ""12341234-app"",
@@ -1474,10 +1475,10 @@ public void Issue2205 ([Values(false, true)] bool useAapt2)
         }
     ],
     ""configuration_version"": ""1""
-}"));
-			using (var b = CreateApkBuilder(Path.Combine("temp", TestName)))
-			{
-				Assert.IsTrue(b.Build(proj), "first build should have succeeded");
+}"
+			});
+			using (var b = CreateApkBuilder (Path.Combine ("temp", TestName))) {
+				Assert.IsTrue (b.Build (proj), "first build should have succeeded");
 			}
 		}
 	}