Skip to content

Commit a34e061

Browse files
[nativeaot] remove extraneous log messages
Context: #9824 With `debug.dotnetlog` support implemented, the lref/gref logging seems sufficient for debugging Java interop (or GC)-related issues. Remove other logging in `NativeAotTypeManager` that seems unnecessary and will yield better startup performance.
1 parent b217dca commit a34e061

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

src/Microsoft.Android.Runtime.NativeAOT/Android.Runtime.NativeAOT/NativeAotTypeManager.cs

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ partial class NativeAotTypeManager : JniRuntime.JniTypeManager {
1515

1616
public NativeAotTypeManager ()
1717
{
18-
AndroidLog.Print (AndroidLogLevel.Info, "NativeAotTypeManager", $"NativeAotTypeManager()");
1918
var startTicks = global::System.Environment.TickCount;
2019
InitializeTypeMappings ();
2120
var endTicks = global::System.Environment.TickCount;
@@ -80,16 +79,12 @@ public override void RegisterNativeMembers (
8079
Type type,
8180
ReadOnlySpan<char> methods)
8281
{
83-
AndroidLog.Print (AndroidLogLevel.Info, "NativeAotTypeManager", $"# jonp: RegisterNativeMembers: nativeClass={nativeClass} type=`{type}`");
84-
8582
if (methods.IsEmpty) {
86-
AndroidLog.Print (AndroidLogLevel.Info, "NativeAotTypeManager", "methods.IsEmpty");
8783
return;
8884
}
8985

9086
int methodCount = CountMethods (methods);
9187
if (methodCount < 1) {
92-
AndroidLog.Print (AndroidLogLevel.Info, "NativeAotTypeManager", $"methodCount < 1: {methodCount}");
9388
return;
9489
}
9590

@@ -122,7 +117,6 @@ public override void RegisterNativeMembers (
122117
callbackDeclaringType = callbackDeclaringType.BaseType!;
123118
}
124119

125-
AndroidLog.Print (AndroidLogLevel.Info, "NativeAotTypeManager", $"# jonp: Delegate.CreateDelegate callbackDeclaringType={callbackDeclaringType}, callbackString={callbackString}");
126120
GetCallbackHandler connector = (GetCallbackHandler) Delegate.CreateDelegate (typeof (GetCallbackHandler),
127121
callbackDeclaringType, callbackString.ToString ());
128122
callback = connector ();
@@ -137,24 +131,18 @@ public override void RegisterNativeMembers (
137131
methodsSpan = newLineIndex != -1 ? methodsSpan.Slice (newLineIndex + 1) : default;
138132
}
139133

140-
AndroidLog.Print (AndroidLogLevel.Info, "NativeAotTypeManager", $"# jonp: needToRegisterNatives={needToRegisterNatives}");
141-
142134
if (needToRegisterNatives) {
143-
AndroidLog.Print (AndroidLogLevel.Info, "NativeAotTypeManager", $"# jonp: RegisterNatives: nativeClass={nativeClass} type=`{type}` natives={natives.Length} nativesIndex={nativesIndex}");
144135
JniEnvironment.Types.RegisterNatives (nativeClass.PeerReference, natives, nativesIndex);
145136
}
146137
}
147138

148139

149140
protected override IEnumerable<Type> GetTypesForSimpleReference (string jniSimpleReference)
150141
{
151-
AndroidLog.Print (AndroidLogLevel.Info, "NativeAotTypeManager", $"# jonp: GetTypesForSimpleReference: jniSimpleReference=`{jniSimpleReference}`");
152142
if (TypeMappings.TryGetValue (jniSimpleReference, out var target)) {
153-
Console.WriteLine ($"# jonp: GetTypesForSimpleReference: jniSimpleReference=`{jniSimpleReference}` -> `{target}`");
154143
yield return target;
155144
}
156145
foreach (var t in base.GetTypesForSimpleReference (jniSimpleReference)) {
157-
AndroidLog.Print (AndroidLogLevel.Info, "NativeAotTypeManager", $"# jonp: GetTypesForSimpleReference: jniSimpleReference=`{jniSimpleReference}` -> `{t}`");
158146
yield return t;
159147
}
160148
}

0 commit comments

Comments
 (0)