Skip to content

Commit 5b21404

Browse files
fixes
* proguard.cfg needed to prevent runtime crash (even with dx + proguard) * fixes for r8
1 parent 4d3fd2a commit 5b21404

File tree

4 files changed

+5
-1
lines changed

4 files changed

+5
-1
lines changed

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,7 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved.
284284
<AndroidDexGenerator Condition=" '$(AndroidDexGenerator)' == '' ">dx</AndroidDexGenerator>
285285
<!-- NOTE: $(AndroidLinkTool) would be blank if code shrinking is not used at all -->
286286
<AndroidLinkTool Condition=" '$(AndroidLinkTool)' == '' And '$(AndroidEnableProguard)' == 'True' ">proguard</AndroidLinkTool>
287+
<AndroidEnableProguard Condition=" '$(AndroidLinkTool)' != '' ">True</AndroidEnableProguard>
287288
<AndroidEnableDesugar Condition=" '$(AndroidEnableDesugar)' == '' And ('$(AndroidDexGenerator)' == 'd8' Or '$(AndroidLinkTool)' == 'r8') ">True</AndroidEnableDesugar>
288289
<AndroidEnableDesugar Condition=" '$(AndroidEnableDesugar)' == '' ">False</AndroidEnableDesugar>
289290

src/Xamarin.Android.Build.Tasks/Xamarin.Android.D8.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ Copyright (C) 2018 Xamarin. All rights reserved.
9393
</CreateItem>
9494

9595
<R8
96-
Condition=" '$(AndroidLinkTool)' == 'r8' "
96+
Condition=" '$(AndroidLinkTool)' == 'r8' and '$(_ProguardProjectConfiguration)' != '' "
9797
ToolPath="$(JavaToolPath)"
9898
JavaMaximumHeapSize="$(JavaMaximumHeapSize)"
9999
JavaOptions="$(JavaOptions)"

tests/Xamarin.Forms-Performance-Integration/Droid/Xamarin.Forms.Performance.Integration.Droid.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@
136136
<None Include="Properties\AndroidManifest.xml" />
137137
<None Include="Resources\AboutResources.txt" />
138138
<None Include="packages.config" />
139+
<ProguardConfiguration Include="proguard.cfg" />
139140
</ItemGroup>
140141
<ItemGroup>
141142
<Compile Include="Properties\AssemblyInfo.cs" />
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
-keep class android.support.v7.widget.** { *; }
2+
-dontwarn android.support.v7.widget.*

0 commit comments

Comments
 (0)