Commit 3576678
[build] use relative paths for <GitBlame/> (#2594)
Downstream in monodroid, I'm getting a build failure such as:
/usr/bin/git blame "/full/path/to/external/xamarin-android/Configuration.props"
XAVersionInfo.targets(53,5): error MSB6006: "git" exited with code 128.
XAVersionInfo.targets(61,5): error MSB4044: The "GitCommitsInRange" task was not given a value for the required parameter "StartCommit".
If I run the git command manually:
fatal: not a git repository (or any of the parent directories): .git
Turns Out™ that some `git` versions are seemingly not happy when
given a full path name, i.e. this sequence of command can fail:
$ cd /full/path/to/xamarin-android
$ git blame `pwd`/Configuration.props
Appease these `git` versions and update the `<GitBlame>` invocation
to use a relative path, effectively doing:
$ cd /full/path/to/xamarin-android
$ git blame Configuration.props1 parent 812d350 commit 3576678
File tree
2 files changed
+2
-2
lines changed- build-tools
- scripts
- xa-prep-tasks/Xamarin.Android.BuildTools.PrepTasks
2 files changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| |||
0 commit comments