From 178ce7d706aa3367855a4da02e00577e55a477b4 Mon Sep 17 00:00:00 2001 From: Pieterjan Van Saet Date: Mon, 11 Oct 2021 13:08:15 +0200 Subject: [PATCH 1/4] fix(switch): not passing value --- packages/switch/Readme.md | 3 ++- packages/switch/src/Switch.jsx | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/switch/Readme.md b/packages/switch/Readme.md index 63545842..d5b67c9a 100644 --- a/packages/switch/Readme.md +++ b/packages/switch/Readme.md @@ -7,5 +7,6 @@ required={true} disabled={false} checked={true} - onClick={(value) => console.log('select value is:', value)} /> + onClick={(value) => console.log('select value is:', value)} + onChecked={(value) => console.log('checked value is:', value)} /> ``` diff --git a/packages/switch/src/Switch.jsx b/packages/switch/src/Switch.jsx index 92bf5164..b757f34f 100644 --- a/packages/switch/src/Switch.jsx +++ b/packages/switch/src/Switch.jsx @@ -8,6 +8,7 @@ interface IProps { labelTrue: string; labelFalse: string; onClick?: (event) => void; + onChecked?: (checked) => void; disabled?: boolean; ariaLabel?: string; qa?: string; @@ -34,6 +35,10 @@ class Switch extends Component { if (this.props.onClick && (typeof this.props.onClick === 'function')) { this.props.onClick(e); } + + if (this.props.onChecked && (typeof this.props.onChecked === 'function')) { + this.props.onChecked(!this.state.checked); + } } render() { From 7f189e8e1165af36387187ffb79b5ab867575e37 Mon Sep 17 00:00:00 2001 From: Pieterjan Van Saet Date: Mon, 11 Oct 2021 13:09:00 +0200 Subject: [PATCH 2/4] chore: add changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3febea69..f5372a21 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/). ## [Unreleased] +### Fixed +- `Switch` - not passing correct value. ## v6.0.6 - 2021-10-08 From 890caef771fef59ee97e57f11ce2e9ed2c12392c Mon Sep 17 00:00:00 2001 From: Pieterjan Van Saet Date: Mon, 11 Oct 2021 13:47:38 +0200 Subject: [PATCH 3/4] fix: remove async --- packages/icon/src/Icon.js | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/packages/icon/src/Icon.js b/packages/icon/src/Icon.js index c2b4edba..ac9af663 100644 --- a/packages/icon/src/Icon.js +++ b/packages/icon/src/Icon.js @@ -23,20 +23,22 @@ const Icon = ({ name, style, className, ariaLabel, onClick, src, qa }: Props) => /** * Inject SVG icons from core branding into page */ - const fetchAntwerpIcons = async function() { + const fetchAntwerpIcons = function() { if (!fetch) return; + try { const xlinkHref = 'https://cdn.antwerpen.be/core_branding_scss/5.0.0/assets/images/ai.svg'; - const response = await fetch(xlinkHref); - const svgText = await response.text(); - - const svgWrapper = document.createElement('svg'); - - svgWrapper.id = 'aiSvg'; - svgWrapper.innerHTML = svgText; - if(!document.getElementById('aiSvg')) { - document.body.appendChild(svgWrapper); - } + const response = fetch(xlinkHref) + .then((response) => response.text()) + .then((svgText) => { + const svgWrapper = document.createElement('svg'); + + svgWrapper.id = 'aiSvg'; + svgWrapper.innerHTML = svgText; + if(!document.getElementById('aiSvg')) { + document.body.appendChild(svgWrapper); + } + }); } catch(err) { throw new Error(err); } From ce50b7122efff49da9d0037ad02c35c75b68b09f Mon Sep 17 00:00:00 2001 From: Pieterjan Van Saet Date: Tue, 16 Nov 2021 08:37:01 +0100 Subject: [PATCH 4/4] feat: update docs --- packages/switch/Readme.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/switch/Readme.md b/packages/switch/Readme.md index d5b67c9a..b0c18a46 100644 --- a/packages/switch/Readme.md +++ b/packages/switch/Readme.md @@ -1,3 +1,6 @@ +- `onClick` will pass the element that was clicked +- `onChecked` will pass `true` of `false` based on if the checkbox is checked + ```