Story/cite 163 - We need a bulk upload for files. #24
+43
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 27, 2025
jdamerow
requested changes
Mar 19, 2025
| HttpEntity<ArrayNode> data = new HttpEntity<ArrayNode>(jsonArray); | ||
|
|
||
| try { | ||
| return restTemplate.exchange(buildUri(url, false), HttpMethod.POST, data, ItemCreationResponse.class) |
Member
There was a problem hiding this comment.
this should use the buildGroupUri method or is there a reason it is not used here?
jdamerow
requested changes
Apr 29, 2025
|
|
||
| JsonNode dataAsJson = mapper.createObjectNode() | ||
| .put("name", collectionName) | ||
| .put("parentCollection", parentCollection); |
Member
There was a problem hiding this comment.
what if there is no parent collection? will this be null or should it just be omitted? the Zotero API documentation doesn't seem to say anything about that, have you tried it?
Contributor
Author
There was a problem hiding this comment.
I have tested this, when there's parent collection, the new collection gets added as child to parent collection. Else the new collection is added directly to group. I have kept this because as there might be cases when parent collection is present.
| } | ||
|
|
||
| @Override | ||
| public ItemCreationResponse createCollection(String groupId, String collectionName, String parentCollection) throws ZoteroConnectionException { |
Member
There was a problem hiding this comment.
needs javadoc (especially addressing my question below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
https://diging.atlassian.net/browse/CITE-163
We need a bulk upload for files.
...Put description here...
The user would create a BibText export that includes files via Zotero (Zotero -> export collection -> BibTex format with "include files" checked). They would then zip the folder that Zotero exports and upload it to Citesphere. Citesphere would send it to the Citesphere Importer component (via Kafka like the other imports) and the importer would then create references in the zotero group the user specifies for the import (like for the web of science import that has no files) and send the files to Giles for processing (similar to how Giles sends individual files to Giles for processing).
Anything else the reviewer needs to know?
... describe here ...