Add error-prone.picnic.tech featuring StaticImport

Author: Vincent Potucek

build.gradle

@@ -12,6 +12,7 @@ repositories {
 apply from: rootProject.file('gradle/java-publish.gradle')
 apply from: rootProject.file('gradle/changelog.gradle')
 allprojects {
+	apply from: rootProject.file('gradle/error-prone.gradle')
 	apply from: rootProject.file('gradle/rewrite.gradle')
 	apply from: rootProject.file('gradle/spotless.gradle')
 }

gradle/error-prone.gradle

@@ -0,0 +1,62 @@
+import static java.lang.System.getenv
+
+apply plugin: 'net.ltgt.errorprone'
+
+dependencies {
+	errorprone('com.google.errorprone:error_prone_core:2.42.0')
+	errorprone('tech.picnic.error-prone-support:error-prone-contrib:0.25.0')
+	errorprone('tech.picnic.error-prone-support:refaster-runner:0.25.0')
+}
+
+tasks.withType(JavaCompile).configureEach {
+	options.errorprone {
+		disableWarningsInGeneratedCode = true
+		error(
+				'ConstantNaming',
+				'EmptyMethod',
+				'EmptyMonoZip',
+				'LexicographicalAnnotationAttributeListing',
+				'LexicographicalAnnotationListing',
+				'MissingOverride',
+				'MissingTestCall',
+				'NonEmptyMono',
+				'OptionalMapUnusedValue',
+				'OptionalOfRedundantMethod',
+				'RedundantSetterCall',
+				'RedundantStringConversion',
+				'RedundantStringEscape',
+				'StaticImport',
+				'StringJoin',
+				'UnnecessaryCheckNotNull',
+				'UnnecessaryTypeArgument',
+				'UnusedAnonymousClass',
+				'UnusedCollectionModifiedInPlace',
+				)
+		errorproneArgs.add('-XepOpt:Refaster:NamePattern=^(?!.*Rules\\$).*')
+		if (!getenv().containsKey('CI') && getenv('IN_PLACE')?.toBoolean()) {
+			errorproneArgs.addAll(
+					'-XepPatchLocation:IN_PLACE',
+					'-XepPatchChecks:' +
+					'ConstantNaming,' +
+					'EmptyMethod,' +
+					'EmptyMonoZip,' +
+					'LexicographicalAnnotationAttributeListing,' +
+					'LexicographicalAnnotationListing,' +
+					'MissingOverride,' +
+					'MissingTestCall,' +
+					'NonEmptyMono,' +
+					'OptionalMapUnusedValue,' +
+					'OptionalOfRedundantMethod,' +
+					'RedundantSetterCall,' +
+					'RedundantStringConversion,' +
+					'RedundantStringEscape,' +
+					'StaticImport,' +
+					'StringJoin,' +
+					'UnnecessaryCheckNotNull,' +
+					'UnnecessaryTypeArgument,' +
+					'UnusedAnonymousClass,' +
+					'UnusedCollectionModifiedInPlace,'
+					)
+		}
+	}
+}

lib-extra/src/cdt/java/com/diffplug/spotless/extra/glue/cdt/EclipseCdtFormatterStepImpl.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2016-2023 DiffPlug
+ * Copyright 2016-2025 DiffPlug
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -15,10 +15,11 @@
  */
 package com.diffplug.spotless.extra.glue.cdt;
 
+import static java.util.stream.Collectors.toMap;
+
 import java.util.Map;
 import java.util.Map.Entry;
 import java.util.Properties;
-import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
 import org.eclipse.cdt.core.formatter.CodeFormatter;
@@ -32,7 +33,7 @@ public class EclipseCdtFormatterStepImpl {
 
 	public EclipseCdtFormatterStepImpl(Properties settings) throws Exception {
 		Stream<Entry<Object, Object>> stream = settings.entrySet().stream();
-		Map<String, String> settingsMap = stream.collect(Collectors.toMap(
+		Map<String, String> settingsMap = stream.collect(toMap(
 				e -> String.valueOf(e.getKey()),
 				e -> String.valueOf(e.getValue())));
 		codeFormatter = org.eclipse.cdt.core.ToolFactory.createDefaultCodeFormatter(settingsMap);

lib-extra/src/groovy/java/com/diffplug/spotless/extra/glue/groovy/GrEclipseFormatterStepImpl.java

@@ -15,12 +15,13 @@
  */
 package com.diffplug.spotless.extra.glue.groovy;
 
+import static java.util.Collections.synchronizedList;
+
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
 import java.nio.file.Files;
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 import java.util.Properties;
@@ -111,7 +112,7 @@ public GroovyErrorListener() {
 			 * We need a synchronized list here, in case multiple instantiations
 			 * run in parallel.
 			 */
-			errors = Collections.synchronizedList(new ArrayList<>());
+			errors = synchronizedList(new ArrayList<>());
 			ILog groovyLogger = GroovyCoreActivator.getDefault().getLog();
 			groovyLogger.addLogListener(this);
 			synchronized (GroovyLogManager.manager) {

lib-extra/src/jdt/java/com/diffplug/spotless/extra/glue/jdt/EclipseJdtFormatterStepImpl.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2016-2024 DiffPlug
+ * Copyright 2016-2025 DiffPlug
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -15,11 +15,12 @@
  */
 package com.diffplug.spotless.extra.glue.jdt;
 
+import static java.util.stream.Collectors.toMap;
+
 import java.io.File;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Properties;
-import java.util.stream.Collectors;
 
 import org.eclipse.jdt.core.formatter.CodeFormatter;
 import org.eclipse.jdt.internal.compiler.env.IModule;
@@ -37,7 +38,7 @@ public class EclipseJdtFormatterStepImpl {
 	private final EclipseJdtSortMembers.SortProperties sortProperties;
 
 	public EclipseJdtFormatterStepImpl(Properties formatterSettings, Map<String, String> sortProperties) {
-		Map<String, String> options = formatterSettings.entrySet().stream().collect(Collectors.toMap(
+		Map<String, String> options = formatterSettings.entrySet().stream().collect(toMap(
 				e -> String.valueOf(e.getKey()),
 				e -> String.valueOf(e.getValue()),
 				(prev, next) -> next,

lib-extra/src/jdt/java/com/diffplug/spotless/extra/glue/jdt/EclipseJdtSortMembers.java

@@ -98,64 +98,84 @@ private static class Buffer implements IBuffer {
 			this.contents = contents;
 		}
 
+		@Override
 		public void addBufferChangedListener(IBufferChangedListener listener) {}
 
+		@Override
 		public void append(char[] text) {}
 
+		@Override
 		public void append(String text) {}
 
+		@Override
 		public void close() {}
 
+		@Override
 		public char getChar(int position) {
 			return '\u0000';
 		}
 
+		@Override
 		public char[] getCharacters() {
 			return contents.toCharArray();
 		}
 
+		@Override
 		public String getContents() {
 			return contents;
 		}
 
+		@Override
 		public int getLength() {
 			return 0;
 		}
 
+		@Override
 		public IOpenable getOwner() {
 			return null;
 		}
 
+		@Override
 		public String getText(int offset, int length) {
 			return null;
 		}
 
+		@Override
 		public IResource getUnderlyingResource() {
 			return null;
 		}
 
+		@Override
 		public boolean hasUnsavedChanges() {
 			return false;
 		}
 
+		@Override
 		public boolean isClosed() {
 			return false;
 		}
 
+		@Override
 		public boolean isReadOnly() {
 			return true;
 		}
 
+		@Override
 		public void removeBufferChangedListener(IBufferChangedListener listener) {}
 
+		@Override
 		public void replace(int position, int length, char[] text) {}
 
+		@Override
 		public void replace(int position, int length, String text) {}
 
+		@Override
 		public void save(IProgressMonitor progress, boolean force) {}
 
+		@Override
 		public void setContents(char[] contents) {}
 
+		@Override
 		public void setContents(String contents) {
 			this.contents = contents;
 		}

lib-extra/src/main/java/com/diffplug/spotless/extra/EclipseBasedStepBuilder.java

@@ -15,15 +15,16 @@
  */
 package com.diffplug.spotless.extra;
 
+import static java.nio.charset.StandardCharsets.UTF_8;
+import static java.util.Objects.requireNonNull;
+
 import java.io.ByteArrayOutputStream;
 import java.io.File;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.Serializable;
-import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.List;
-import java.util.Objects;
 import java.util.Properties;
 
 import com.diffplug.common.base.Errors;
@@ -69,10 +70,10 @@ public EclipseBasedStepBuilder(String formatterName, Provisioner jarProvisioner,
 
 	/** Initialize valid default configuration, taking latest version */
 	public EclipseBasedStepBuilder(String formatterName, String formatterStepExt, Provisioner jarProvisioner, SerializedFunction<State, FormatterFunc> stateToFormatter) {
-		this.formatterName = Objects.requireNonNull(formatterName, "formatterName");
-		this.formatterStepExt = Objects.requireNonNull(formatterStepExt, "formatterStepExt");
-		this.jarProvisioner = Objects.requireNonNull(jarProvisioner, "jarProvisioner");
-		this.stateToFormatter = Objects.requireNonNull(stateToFormatter, "stateToFormatter");
+		this.formatterName = requireNonNull(formatterName, "formatterName");
+		this.formatterStepExt = requireNonNull(formatterStepExt, "formatterStepExt");
+		this.jarProvisioner = requireNonNull(jarProvisioner, "jarProvisioner");
+		this.stateToFormatter = requireNonNull(stateToFormatter, "stateToFormatter");
 		formatterVersion = "No version set"; //Will fail creation
 	}
 
@@ -91,7 +92,7 @@ public void setVersion(String version) {
 			throw new IllegalArgumentException("No such version " + version + ", expected at " + url);
 		}
 		byte[] content = toByteArray(depsFile);
-		String allLines = new String(content, StandardCharsets.UTF_8);
+		String allLines = new String(content, UTF_8);
 		String[] lines = allLines.split("\n");
 		dependencies.clear();
 		for (String line : lines) {

lib-extra/src/main/java/com/diffplug/spotless/extra/EquoBasedStepBuilder.java

@@ -15,6 +15,7 @@
  */
 package com.diffplug.spotless.extra;
 
+import static java.util.Objects.requireNonNullElse;
 import static java.util.stream.Collectors.toMap;
 
 import java.io.File;
@@ -24,7 +25,6 @@
 import java.util.Collection;
 import java.util.List;
 import java.util.Map;
-import java.util.Objects;
 import java.util.Properties;
 
 import javax.annotation.Nullable;
@@ -190,8 +190,8 @@ static class EquoStep implements Serializable {
 				ImmutableMap<String, String> stepProperties) {
 
 			this.semanticVersion = semanticVersion;
-			this.settingProperties = Objects.requireNonNullElse(settingProperties, new ArrayList<>());
-			this.settingXml = Objects.requireNonNullElse(settingXml, new ArrayList<>());
+			this.settingProperties = requireNonNullElse(settingProperties, new ArrayList<>());
+			this.settingXml = requireNonNullElse(settingXml, new ArrayList<>());
 			this.settingsPromise = settingsPromise;
 			this.jarPromise = jarPromise;
 			this.stepProperties = stepProperties;
@@ -218,8 +218,8 @@ public static class State implements Serializable {
 		public State(String semanticVersion, JarState jarState, List<String> settingProperties, List<String> settingXml, FileSignature settingsFiles, ImmutableMap<String, String> stepProperties) {
 			this.semanticVersion = semanticVersion;
 			this.jarState = jarState;
-			this.settingProperties = Objects.requireNonNullElse(settingProperties, new ArrayList<>());
-			this.settingXml = Objects.requireNonNullElse(settingXml, new ArrayList<>());
+			this.settingProperties = requireNonNullElse(settingProperties, new ArrayList<>());
+			this.settingXml = requireNonNullElse(settingXml, new ArrayList<>());
 			this.settingsFiles = settingsFiles;
 			this.stepProperties = stepProperties;
 		}

lib-extra/src/main/java/com/diffplug/spotless/extra/GitAttributesLineEndings.java

@@ -15,17 +15,18 @@
  */
 package com.diffplug.spotless.extra;
 
+import static java.util.Collections.emptyList;
+import static java.util.Objects.requireNonNull;
+
 import java.io.File;
 import java.io.FileInputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.Serializable;
-import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
-import java.util.Objects;
 import java.util.function.Supplier;
 
 import javax.annotation.Nullable;
@@ -120,8 +121,8 @@ static class RelocatablePolicy extends LazyForwardingEquality<CachedEndings> imp
 		transient Supplier<Iterable<File>> toFormat;
 
 		RelocatablePolicy(File projectDir, Supplier<Iterable<File>> toFormat) {
-			this.projectDir = Objects.requireNonNull(projectDir, "projectDir");
-			this.toFormat = Objects.requireNonNull(toFormat, "toFormat");
+			this.projectDir = requireNonNull(projectDir, "projectDir");
+			this.toFormat = requireNonNull(toFormat, "toFormat");
 		}
 
 		@Override
@@ -260,10 +261,10 @@ static final class Runtime {
 		final String defaultEnding;
 
 		private Runtime(List<AttributesRule> infoRules, @Nullable File workTree, Config config, List<AttributesRule> globalRules) {
-			this.infoRules = Objects.requireNonNull(infoRules);
+			this.infoRules = requireNonNull(infoRules);
 			this.workTree = workTree;
 			this.defaultEnding = findDefaultLineEnding(config).str();
-			this.globalRules = Objects.requireNonNull(globalRules);
+			this.globalRules = requireNonNull(globalRules);
 		}
 
 		private static final String KEY_EOL = "eol";
@@ -389,7 +390,7 @@ private static List<AttributesRule> parseRules(@Nullable File file) {
 				LOGGER.warn("Problem parsing {}", file.getAbsolutePath(), e);
 			}
 		}
-		return Collections.emptyList();
+		return emptyList();
 	}
 
 	/** Parses an attribute value from a list of rules, returning null if there is no match for the given key. */

lib-extra/src/main/java/com/diffplug/spotless/extra/GitWorkarounds.java

@@ -202,8 +202,8 @@ private static IOException emptyFile(File commonDir) {
 			return new IOException("Empty 'commondir' file: " + commonDir.getAbsolutePath());
 		}
 
-		@SuppressFBWarnings("BC_UNCONFIRMED_CAST_OF_RETURN_VALUE")
 		@Override
+		@SuppressFBWarnings("BC_UNCONFIRMED_CAST_OF_RETURN_VALUE")
 		public FileRepositoryBuilder readEnvironment(SystemReader sr) {
 			super.readEnvironment(sr);