fix: hide icon from visualization when option is toggled

edoardo · edoardo · commit 3e0f0862b56f · 2023-04-20T13:48:10.000+02:00
This didn't work before because the icons option was removed from the
options object, but when the current object was merged with
the new options, it retained the original value.
diff --git a/src/modules/current.js b/src/modules/current.js
@@ -84,7 +84,7 @@ export const getOptionsFromUi = (ui) => {
         optionsFromUi.icons = [{ type: 'DATA_ITEM' }]
     } else {
         // if options is not enabled, do not pass the "internal" boolean value
-        delete optionsFromUi.icons
+        optionsFromUi.icons = undefined
     }
 
     // nested options under reportingParams

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ export const getOptionsFromUi = (ui) => {`
`84`	`84`	`optionsFromUi.icons = [{ type: 'DATA_ITEM' }]`
`85`	`85`	`} else {`
`86`	`86`	`// if options is not enabled, do not pass the "internal" boolean value`
`87`		`- delete optionsFromUi.icons`
	`87`	`+ optionsFromUi.icons = undefined`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`// nested options under reportingParams`