Refactor ZendHashTable and Zval
#76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functions actually returned references to the new zval value, so there's not much point in returning.
Replaced by returning references to the actual hashtable, and having a new type `OwnedHashTable` when creating a new hashtable.
vodik
approved these changes
Sep 20, 2021
Collaborator
vodik
left a comment
vodik
left a comment
There was a problem hiding this comment.
I think it looks reasonable to me. Just a few thoughts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZendHashTablehas been split into&HashTableandOwnedHashTable.&HashTableis toOwnedHashTableas&stris toString.Dropimplementation onZvalwill properly drop the contents of the zval.