Merge pull request #3 from quiqua/tests_refactoring

Refactored code and added more tests

Author: quiqua

examples/TestApp.py

@@ -74,9 +74,9 @@ def __init__(self, parent=None):
         self.tableViewColumnDtypes = QtGui.QTableView(self)
         self.rightLayout.addWidget(QtGui.QLabel('dtypes'))
         self.rightLayout.addWidget(self.tableViewColumnDtypes)
-        self.buttonGotToColumn = QtGui.QPushButton("got to column")
-        self.rightLayout.addWidget(self.buttonGotToColumn)
-        self.buttonGotToColumn.clicked.connect(self.gotToColumn)
+        self.buttonGoToColumn = QtGui.QPushButton("go to column")
+        self.rightLayout.addWidget(self.buttonGoToColumn)
+        self.buttonGoToColumn.clicked.connect(self.goToColumn)
 
         self.buttonSetFilter = QtGui.QPushButton("set filter")
         self.rightLayout.addWidget(self.buttonSetFilter)
@@ -123,8 +123,8 @@ def updateDelegates(self, column=None):
         print "update delegate for column", column
         self.delegates = setDelegatesFromDtype(self.dataTableView)
 
-    def gotToColumn(self):
-        print "go to column"
+    def goToColumn(self):
+        print "go to column 7"
         index = self.dataTableView.model().index(7, 0)
         self.dataTableView.setCurrentIndex(index)
 

pandasqt/BigIntSpinbox.py

@@ -23,8 +23,8 @@ def __init__(self, parent=None):
         """the __init__ method.
 
         Args:
-            parent (QObject): defaults to None. If parent is 0, the new widget becomes a window. 
-                If parent is another widget, this widget becomes a child window inside parent. 
+            parent (QObject): defaults to None. If parent is 0, the new widget becomes a window.
+                If parent is another widget, this widget becomes a child window inside parent.
                 The new widget is deleted when its parent is deleted.
 
         """
@@ -97,10 +97,14 @@ def setSingleStep(self, singleStep):
         Args:
             singleStep (int): new _singleStep value. converts negativ values to positiv ones.
 
+        Raises:
+            TypeError: If the given argument is not an integer.
+
         Returns:
-            True if all went fine.
+            int or long: the absolute value of the given argument.
         """
-        assert isinstance(singleStep, int), "not of type int"
+        if not isinstance(singleStep, int):
+            raise TypeError("Argument is not of type int")
         # don't use negative values
         self._singleStep = abs(singleStep)
         return self._singleStep
@@ -113,9 +117,13 @@ def setMinimum(self, minimum):
         """setter to _minimum.
 
         Args:
-            minimum (int or long): new _minimum value
+            minimum (int or long): new _minimum value.
+
+        Raises:
+            TypeError: If the given argument is not an integer.
         """
-        assert isinstance(minimum, int) or isinstance(minimum, long), "not of type int or long"
+        if not isinstance(minimum, (int, long)):
+            raise TypeError("Argument is not of type int or long")
         self._minimum = minimum
 
     def maximum(self):
@@ -127,6 +135,7 @@ def setMaximum(self, maximum):
 
         Args:
             maximum (int or long): new _maximum value
-        """        
-        assert isinstance(maximum, int) or isinstance(maximum, long), "not of type int or long"
+        """
+        if not isinstance(maximum, (int, long)):
+            raise TypeError("Argument is not of type int or long")
         self._maximum = maximum