Exclusively use API reported block schemas to determine if a block is implemented

Author: ml-evs

webapp/src/server_fetch_utils.js

@@ -531,11 +531,9 @@ export async function updateBlockFromServer(
         block_id: block_id,
         isSaved: response_json.saved_successfully,
       });
-      store.commit("setBlockImplementationError", { block_id, hasError: false });
     })
     .catch((error) => {
       console.warn(`Failed to update block ${block_id}:`, error);
-      store.commit("setBlockImplementationError", { block_id, hasError: true });
       store.commit("setBlockNotUpdating", block_id);
     });
 }

webapp/src/store/index.js

@@ -362,13 +362,6 @@ export default createStore({
         ].filter((item) => !refcodes.includes(item.refcode));
       }
     },
-    setBlockImplementationError(state, { block_id, hasError }) {
-      if (hasError) {
-        state.block_implementation_errors[block_id] = true;
-      } else {
-        delete state.block_implementation_errors[block_id];
-      }
-    },
   },
   getters: {
     getItem: (state) => (item_id) => {

webapp/src/views/EditPage.vue

@@ -266,12 +266,11 @@ export default {
       });
     },
     getBlockDisplayType(block_id) {
-      if (this.$store.state.block_implementation_errors[block_id]) {
-        return NotImplementedBlock;
-      }
-
       const block = this.blocks[block_id];
-      if (!block || !block.blocktype) {
+      if (!(block.blocktype in this.$store.state.blocksInfos)) {
+        console.log(
+          `Block with type ${block.blocktype} does not have a valid blocktype or is not in blocksInfos.`,
+        );
         return NotImplementedBlock;
       }