Skip to content

Commit 2fa241e

Browse files
Update env variable fron VUE_ to VITE_
1 parent 003d948 commit 2fa241e

File tree

10 files changed

+270
-275
lines changed

10 files changed

+270
-275
lines changed

.docker/app_dockerfile

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# syntax=docker/dockerfile:1
22
FROM node:20-bullseye AS build
3+
SHELL ["/bin/bash", "--login", "-c"]
34

45
WORKDIR /app
56

@@ -8,22 +9,25 @@ EXPOSE 8081
89
COPY webapp/package.json webapp/yarn.lock ./
910

1011
# Using a custom node_modules location to avoid mounting it outside of docker
11-
RUN --mount=type=cache,target=/root/.cache/yarn yarn install --frozen-lockfile
12+
RUN --mount=type=cache,target=/root/.cache/yarn yarn install --frozen-lockfile --modules-folder /node_modules
1213

1314
ENV NODE_ENV=production
1415

1516
# These get replaced by the entrypoint script for production builds.
1617
# Set the real values in `.env` files or an external docker-compose.
17-
ARG VUE_APP_API_URL=magic-api-url
18-
ARG VUE_APP_LOGO_URL=magic-logo-url
19-
ARG VUE_APP_HOMEPAGE_URL=magic-homepage-url
20-
ARG VUE_APP_EDITABLE_INVENTORY=magic-setting
21-
ARG VUE_APP_WEBSITE_TITLE=magic-title
22-
ARG VUE_APP_QR_CODE_RESOLVER_URL=magic-qr-code-resolver-url
23-
ARG VUE_APP_AUTOMATICALLY_GENERATE_ID_DEFAULT=magic-generate-id-setting
18+
# ARG VITE_APP_API_URL=magic-api-url
19+
ARG VITE_APP_API_URL=$VITE_APP_API_URL
20+
ARG VITE_APP_LOGO_URL=magic-logo-url
21+
ARG VITE_APP_HOMEPAGE_URL=magic-homepage-url
22+
ARG VITE_APP_EDITABLE_INVENTORY=magic-setting
23+
ARG VITE_APP_WEBSITE_TITLE=magic-title
24+
ARG VITE_APP_QR_CODE_RESOLVER_URL=magic-qr-code-resolver-url
25+
ARG VITE_APP_AUTOMATICALLY_GENERATE_ID_DEFAULT=magic-generate-id-setting
2426

2527
COPY webapp ./
26-
RUN --mount=type=bind,target=/.git,src=./.git VUE_APP_GIT_VERSION=$(node scripts/get-version.js) yarn build
28+
RUN --mount=type=bind,target=/.git,src=./.git VITE_APP_GIT_VERSION=$(node scripts/get-version.js)
29+
30+
RUN yarn build
2731

2832
FROM node:20-bullseye AS production
2933

@@ -33,7 +37,7 @@ COPY ./.docker/app_entrypoint.sh /app/
3337
COPY webapp/package.json webapp/yarn.lock ./
3438

3539
COPY --from=build /app/dist /app/dist
36-
RUN --mount=type=cache,target=/root/.cache/yarn yarn install --frozen-lockfile --production
40+
RUN --mount=type=cache,target=/root/.cache/yarn yarn install --frozen-lockfile --modules-folder /node_modules --production
3741

3842
CMD [ "/bin/bash", "-c", "/app/app_entrypoint.sh" ]
3943

.docker/app_entrypoint.sh

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
set -e
99
ROOT_DIR=/app/dist
1010

11-
if [ -z "$VUE_APP_API_URL" ]; then
12-
echo "VUE_APP_API_URL is unset and we are in production mode. Exiting."
11+
if [ -z "$VITE_APP_API_URL" ]; then
12+
echo "VITE_APP_API_URL is unset and we are in production mode. Exiting."
1313
echo ""
1414
echo "Found settings:"
1515
echo ""
@@ -18,37 +18,37 @@ if [ -z "$VUE_APP_API_URL" ]; then
1818
exit 1
1919
fi
2020

21-
# If the VUE_APP_GIT_VERSION has not been overridden, set it to the default
21+
# If the VITE_APP_GIT_VERSION has not been overridden, set it to the default
2222
# from package.json; the real `.git` version, if available, should still
2323
# take precedence.
24-
if [ -z "$VUE_APP_GIT_VERSION" ]; then
25-
VUE_APP_GIT_VERSION="0.0.0-git"
24+
if [ -z "$VITE_APP_GIT_VERSION" ]; then
25+
VITE_APP_GIT_VERSION="0.0.0-git"
2626
fi
2727

2828
echo "Replacing env vars in Javascript files"
2929
echo "Settings:"
3030
echo ""
31-
echo " APP_VERSION: ${VUE_APP_GIT_VERSION}"
32-
echo " API_URL: ${VUE_APP_API_URL}"
33-
echo " LOGO_URL: ${VUE_APP_LOGO_URL}"
34-
echo " HOMEPAGE_URL: ${VUE_APP_HOMPAGE_URL}"
35-
echo " EDITABLE_INVENTORY: ${VUE_APP_EDITABLE_INVENTORY}"
36-
echo " WEBSITE_TITLE: ${VUE_APP_WEBSITE_TITLE}"
37-
echo " QR_CODE_RESOLVER_URL: ${VUE_APP_QR_CODE_RESOLVER_URL}"
38-
echo " AUTOMATICALLY_GENERATE_ID_DEFAULT: ${VUE_APP_AUTOMATICALLY_GENERATE_ID_DEFAULT}"
31+
echo " APP_VERSION: ${VITE_APP_GIT_VERSION}"
32+
echo " API_URL: ${VITE_APP_API_URL}"
33+
echo " LOGO_URL: ${VITE_APP_LOGO_URL}"
34+
echo " HOMEPAGE_URL: ${VITE_APP_HOMPAGE_URL}"
35+
echo " EDITABLE_INVENTORY: ${VITE_APP_EDITABLE_INVENTORY}"
36+
echo " WEBSITE_TITLE: ${VITE_APP_WEBSITE_TITLE}"
37+
echo " QR_CODE_RESOLVER_URL: ${VITE_APP_QR_CODE_RESOLVER_URL}"
38+
echo " AUTOMATICALLY_GENERATE_ID_DEFAULT: ${VITE_APP_AUTOMATICALLY_GENERATE_ID_DEFAULT}"
3939
echo ""
4040
echo "Patching..."
4141

4242
for file in $ROOT_DIR/js/app.*.js* $ROOT_DIR/*html; do
4343
echo "$file"
44-
sed -i "s|0.0.0-git|${VUE_APP_GIT_VERSION}|g" $file
45-
sed -i "s|magic-api-url|${VUE_APP_API_URL}|g" $file
46-
sed -i "s|magic-logo-url|${VUE_APP_LOGO_URL}|g" $file
47-
sed -i "s|magic-homepage-url|${VUE_APP_HOMEPAGE_URL}|g" $file
48-
sed -i "s|magic-setting|${VUE_APP_EDITABLE_INVENTORY}|g" $file
49-
sed -i "s|magic-title|${VUE_APP_WEBSITE_TITLE}|g" $file
50-
sed -i "s|magic-qr-code-resolver-url|${VUE_APP_QR_CODE_RESOLVER_URL}|g" $file
51-
sed -i "s|magic-generate-id-setting|${VUE_APP_AUTOMATICALLY_GENERATE_ID_DEFAULT}|g" $file
44+
sed -i "s|0.0.0-git|${VITE_APP_GIT_VERSION}|g" $file
45+
sed -i "s|magic-api-url|${VITE_APP_API_URL}|g" $file
46+
sed -i "s|magic-logo-url|${VITE_APP_LOGO_URL}|g" $file
47+
sed -i "s|magic-homepage-url|${VITE_APP_HOMEPAGE_URL}|g" $file
48+
sed -i "s|magic-setting|${VITE_APP_EDITABLE_INVENTORY}|g" $file
49+
sed -i "s|magic-title|${VITE_APP_WEBSITE_TITLE}|g" $file
50+
sed -i "s|magic-qr-code-resolver-url|${VITE_APP_QR_CODE_RESOLVER_URL}|g" $file
51+
sed -i "s|magic-generate-id-setting|${VITE_APP_AUTOMATICALLY_GENERATE_ID_DEFAULT}|g" $file
5252
done
5353

5454
echo "Done!"

0 commit comments

Comments
 (0)