closing connection once data diff is executed (#785)

* closing connection once data diff is executed

Signed-off-by: Sarad Mohanan <[email protected]>

* typo fix

Signed-off-by: Sarad Mohanan <[email protected]>

* moving database to with block

Signed-off-by: Sarad Mohanan <[email protected]>

* optimizing _data_diff function

Signed-off-by: Sarad Mohanan <[email protected]>

* minor

Signed-off-by: Sarad Mohanan <[email protected]>

* minor

Signed-off-by: Sarad Mohanan <[email protected]>

* bug fix

Signed-off-by: Sarad Mohanan <[email protected]>

* linter fixes

Signed-off-by: Sarad Mohanan <[email protected]>

* formating code

Signed-off-by: Sarad Mohanan <[email protected]>

* update CONTRIBUTING.md and cleanup ansi escape sequences

Signed-off-by: Sarad Mohanan <[email protected]>

* read postgres db config from common.CONN_STRINGS

Signed-off-by: Sarad Mohanan <[email protected]>

* defaulting postgres port

Signed-off-by: Sarad Mohanan <[email protected]>

* test

Signed-off-by: Sarad Mohanan <[email protected]>

* test for __main__

Signed-off-by: Sarad Mohanan <[email protected]>

* adding close db connection test

Signed-off-by: Sarad Mohanan <[email protected]>

* update test case

Signed-off-by: Sarad Mohanan <[email protected]>

* do not use shared connection

Signed-off-by: Sarad Mohanan <[email protected]>

* no connection sharing

Signed-off-by: Sarad Mohanan <[email protected]>

* no connection sharing

Signed-off-by: Sarad Mohanan <[email protected]>

* avoid list typing

Signed-off-by: Sarad Mohanan <[email protected]>

* Update tests/test_main.py

Co-authored-by: Sung Won Chung <[email protected]>

* Update tests/test_main.py

Co-authored-by: Sung Won Chung <[email protected]>

* Apply suggestions from code review

Co-authored-by: Sung Won Chung <[email protected]>

* Update tests/test_database.py

Co-authored-by: Sung Won Chung <[email protected]>

* minor

Signed-off-by: Sarad Mohanan <[email protected]>

* minor

Signed-off-by: Sarad Mohanan <[email protected]>

* minor

Signed-off-by: Sarad Mohanan <[email protected]>

* minor

Signed-off-by: Sarad Mohanan <[email protected]>

* merging 784

Signed-off-by: Sarad Mohanan <[email protected]>

* remove redundant variable

Signed-off-by: Sarad Mohanan <[email protected]>

---------

Signed-off-by: Sarad Mohanan <[email protected]>
Co-authored-by: Sung Won Chung <[email protected]>

Author: sar009

.gitignore

@@ -149,4 +149,6 @@ benchmark_*.png
 .vscode
 
 # History
-.history
+.history
+
+docker-compose-local.yml

CONTRIBUTING.md

@@ -66,7 +66,7 @@ Make sure to update the appropriate `TEST_*_CONN_STRING`, so that it will be inc
 
 #### Run the tests
 
-You can run the tests with `unittest`.
+You can run the tests with `python -m unittest`.
 
 When running against multiple databases, the tests can take a long while.
 
@@ -111,6 +111,15 @@ $ poetry install # Install dependencies
 $ docker-compose up -d mysql postgres # run mysql and postgres dbs in background
 ```
 
+If you want to change the configuration of docker-compose and run the DB containers, copy docker-compose.yml into docker-compose-local.yml, make changes and run
+```shell-session
+$ cp docker-compose.yml docker-compose-local.yml
+$ docker-compose -f docker-compose-local.yml up -d mysql postgres # run mysql and postgres dbs in background
+ ```
+you will also have to set up `tests/local_settings.py` where `TEST_*_CONN_STRING` can be edited
+
+`docker-compose-local.yml` and `tests/local_settings.py` is git ignored so should not show up in git changes.
+
 [docker-compose]: https://docs.docker.com/compose/install/
 
 **3. Run Unit Tests**