Skip to content

Commit 8c77103

Browse files
Tanchwankvuong
authored andcommitted
fixed null string value issues; was accidentally using (types.String).String instead of (types.String).ValueString
1 parent ac8025c commit 8c77103

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

internal/providers/pluginfw/products/permission/resource_permission.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ func (v accessControlListValidator) MarkdownDescription(ctx context.Context) str
9292
func (v accessControlListValidator) ValidateObject(ctx context.Context, req validator.ObjectRequest, resp *validator.ObjectResponse) {
9393
var userName, groupName, spID types.String
9494

95-
// You must check for each field using its path
9695
if diags := req.Config.GetAttribute(ctx, path.Root("access_control").AtName("user_name"), &userName); diags.HasError() {
9796
resp.Diagnostics.Append(diags...)
9897
return
@@ -188,14 +187,15 @@ func (r *PermissionResource) Create(ctx context.Context, req resource.CreateRequ
188187
if resp.Diagnostics.HasError() {
189188
return
190189
}
191-
192190

191+
192+
193193
// generate API request from plan
194194
var acl iam.AccessControlRequest
195-
acl.ServicePrincipalName = strings.Trim(plan.AccessControlList.ServicePrincipalId.String(), "\"")
196-
acl.GroupName = strings.Trim(plan.AccessControlList.GroupName.String(), "\"")
197-
acl.UserName = strings.Trim(plan.AccessControlList.UserName.String(), "\"")
198-
acl.PermissionLevel = iam.PermissionLevel(strings.Trim(plan.AccessControlList.PermissionLevel.String(), "\""))
195+
acl.ServicePrincipalName = plan.AccessControlList.ServicePrincipalId.ValueString()
196+
acl.UserName = plan.AccessControlList.UserName.ValueString()
197+
acl.GroupName = plan.AccessControlList.GroupName.ValueString()
198+
acl.PermissionLevel = iam.PermissionLevel(plan.AccessControlList.PermissionLevel.ValueString())
199199

200200

201201
// create the permission

0 commit comments

Comments
 (0)