From 2460ec8a04ecd7ee5ba1fa4f162a217dc3726168 Mon Sep 17 00:00:00 2001 From: Anna Gringauze Date: Tue, 24 Jan 2023 16:52:01 -0800 Subject: [PATCH 1/3] Update vm_service to version 10.0.0 --- dwds/CHANGELOG.md | 1 + dwds/lib/src/services/chrome_proxy_service.dart | 4 ++-- dwds/pubspec.yaml | 2 +- webdev/CHANGELOG.md | 1 + webdev/pubspec.yaml | 2 +- 5 files changed, 6 insertions(+), 4 deletions(-) diff --git a/dwds/CHANGELOG.md b/dwds/CHANGELOG.md index e089febe1..7bcd6e100 100644 --- a/dwds/CHANGELOG.md +++ b/dwds/CHANGELOG.md @@ -18,6 +18,7 @@ - Make hot restart atomic to prevent races on simultaneous execution. - Return error on expression evaluation if expression evaluator stopped. - Update SDK constraint to `>=3.0.0-134.0.dev <4.0.0`. +- Update `package:vm_service` to `10.0.0`. **Breaking changes** - Include an optional param to `Dwds.start` to indicate whether it is running diff --git a/dwds/lib/src/services/chrome_proxy_service.dart b/dwds/lib/src/services/chrome_proxy_service.dart index c317aff90..727c3a76e 100644 --- a/dwds/lib/src/services/chrome_proxy_service.dart +++ b/dwds/lib/src/services/chrome_proxy_service.dart @@ -561,8 +561,8 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension( } @override - Future getInstances( - String isolateId, String classId, int limit) { + Future getInstances(String isolateId, String classId, int limit, + {bool? includeImplementers, bool? includeSubclasses}) { return _rpcNotSupportedFuture('getInstances'); } diff --git a/dwds/pubspec.yaml b/dwds/pubspec.yaml index e43ec5103..d82a0692b 100644 --- a/dwds/pubspec.yaml +++ b/dwds/pubspec.yaml @@ -34,7 +34,7 @@ dependencies: stack_trace: ^1.10.0 sse: ^4.1.2 uuid: ^3.0.6 - vm_service: ^9.0.0 + vm_service: ^10.0.0 web_socket_channel: ^2.2.0 webkit_inspection_protocol: ^1.0.1 diff --git a/webdev/CHANGELOG.md b/webdev/CHANGELOG.md index 4f927eb47..78c06cad2 100644 --- a/webdev/CHANGELOG.md +++ b/webdev/CHANGELOG.md @@ -3,6 +3,7 @@ - Add `--enable-experiment` flag to webdev commands and pass it to the build runner and the expression compiler service. - Update SDK constraint to `>=3.0.0-134.0.dev <4.0.0`. +- Update `package:vm_service` to `10.0.0`. **Breaking changes** diff --git a/webdev/pubspec.yaml b/webdev/pubspec.yaml index 0e9f49512..11dff70d2 100644 --- a/webdev/pubspec.yaml +++ b/webdev/pubspec.yaml @@ -35,7 +35,7 @@ dependencies: shelf_static: ^1.1.0 stack_trace: ^1.10.0 sse: ^4.1.0 - vm_service: ^9.0.0 + vm_service: ^10.0.0 webkit_inspection_protocol: ^1.0.1 yaml: ^3.1.1 From 08d4a10f70de0ade0b9b5d9050538362316cf290 Mon Sep 17 00:00:00 2001 From: Anna Gringauze Date: Tue, 24 Jan 2023 16:58:10 -0800 Subject: [PATCH 2/3] Format --- dwds/lib/src/services/chrome_proxy_service.dart | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/dwds/lib/src/services/chrome_proxy_service.dart b/dwds/lib/src/services/chrome_proxy_service.dart index 727c3a76e..766f3e909 100644 --- a/dwds/lib/src/services/chrome_proxy_service.dart +++ b/dwds/lib/src/services/chrome_proxy_service.dart @@ -561,8 +561,13 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension( } @override - Future getInstances(String isolateId, String classId, int limit, - {bool? includeImplementers, bool? includeSubclasses}) { + Future getInstances( + String isolateId, + String classId, + int limit, { + bool? includeImplementers, + bool? includeSubclasses, + }) { return _rpcNotSupportedFuture('getInstances'); } From 82d87fa72bee23790f0cea82e3cfdd8e2ac09626 Mon Sep 17 00:00:00 2001 From: Anna Gringauze Date: Wed, 25 Jan 2023 08:58:34 -0800 Subject: [PATCH 3/3] Update vm_service constraints --- dwds/CHANGELOG.md | 2 +- dwds/pubspec.yaml | 2 +- webdev/CHANGELOG.md | 2 +- webdev/pubspec.yaml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dwds/CHANGELOG.md b/dwds/CHANGELOG.md index 7bcd6e100..cd411a853 100644 --- a/dwds/CHANGELOG.md +++ b/dwds/CHANGELOG.md @@ -18,7 +18,7 @@ - Make hot restart atomic to prevent races on simultaneous execution. - Return error on expression evaluation if expression evaluator stopped. - Update SDK constraint to `>=3.0.0-134.0.dev <4.0.0`. -- Update `package:vm_service` to `10.0.0`. +- Update `package:vm_service` constraint to `>=10.1.0 <12.0.0`. **Breaking changes** - Include an optional param to `Dwds.start` to indicate whether it is running diff --git a/dwds/pubspec.yaml b/dwds/pubspec.yaml index d82a0692b..cba1ec42a 100644 --- a/dwds/pubspec.yaml +++ b/dwds/pubspec.yaml @@ -34,7 +34,7 @@ dependencies: stack_trace: ^1.10.0 sse: ^4.1.2 uuid: ^3.0.6 - vm_service: ^10.0.0 + vm_service: ">=10.1.0 <12.0.0" web_socket_channel: ^2.2.0 webkit_inspection_protocol: ^1.0.1 diff --git a/webdev/CHANGELOG.md b/webdev/CHANGELOG.md index 78c06cad2..b3223a0dd 100644 --- a/webdev/CHANGELOG.md +++ b/webdev/CHANGELOG.md @@ -3,7 +3,7 @@ - Add `--enable-experiment` flag to webdev commands and pass it to the build runner and the expression compiler service. - Update SDK constraint to `>=3.0.0-134.0.dev <4.0.0`. -- Update `package:vm_service` to `10.0.0`. +- Update `package:vm_service` constraint to `>=10.1.0 <12.0.0`. **Breaking changes** diff --git a/webdev/pubspec.yaml b/webdev/pubspec.yaml index 11dff70d2..ece33607c 100644 --- a/webdev/pubspec.yaml +++ b/webdev/pubspec.yaml @@ -35,7 +35,7 @@ dependencies: shelf_static: ^1.1.0 stack_trace: ^1.10.0 sse: ^4.1.0 - vm_service: ^10.0.0 + vm_service: ">=10.1.0 <12.0.0" webkit_inspection_protocol: ^1.0.1 yaml: ^3.1.1