Enable remaining Windows suppressed tests (#722)

Author: alan-knight

.travis.yml

@@ -40,7 +40,7 @@ jobs:
       env: PKGS="dwds"
       script: ./tool/travis.sh test_0
     - stage: unit_test
-      name: "SDK: stable; PKG: dwds; TASKS: `pub run test`"
+      name: "SDK: stable; PKG: dwds; TASKS: `pub run test -j 1`"
       dart: stable
       os: windows
       env: PKGS="dwds"

dwds/lib/src/debugging/sources.dart

@@ -6,6 +6,7 @@ import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
+import 'package:http/http.dart';
 import 'package:logging/logging.dart';
 import 'package:path/path.dart' as p;
 import 'package:source_maps/source_maps.dart';
@@ -157,10 +158,18 @@ class Sources {
   /// [HttpStatus.ok].
   Future<String> _readAssetOrNull(String path) async {
     var response = await _assetHandler.getRelativeAsset(path);
-    if (response.statusCode == HttpStatus.ok) {
-      return response.readAsString();
+    var responseText = '';
+    var hasError = false;
+    try {
+      responseText = await response.readAsString();
+    } on ClientException {
+      hasError = true;
+      responseText = '<response not available>';
     }
-    _logWriter(Level.WARNING, '''
+    if (response.statusCode == HttpStatus.ok && !hasError) {
+      return responseText;
+    } else {
+      _logWriter(Level.WARNING, '''
 Failed to load asset at path: $path.
 
 Status code: ${response.statusCode}
@@ -169,9 +178,10 @@ Headers:
 ${const JsonEncoder.withIndent('  ').convert(response.headers)}
 
 Content:
-${await response.readAsString()}
+$responseText}
 ''');
-    return null;
+      return null;
+    }
   }
 
   /// The source map for a DDC-compiled JS [script].

dwds/test/chrome_proxy_service_test.dart

@@ -126,12 +126,15 @@ void main() {
           1: 2,
           false: true,
         };
+
         var result =
             await service.callServiceExtension(serviceMethod, args: args);
         expect(
             result.json,
             args.map((k, v) => MapEntry(k is String ? k : jsonEncode(k),
                 v is String ? v : jsonEncode(v))));
+      }, onPlatform: {
+        'windows': const Skip('https://github.com/dart-lang/webdev/issues/711'),
       });
 
       test('failure', () async {
@@ -149,6 +152,8 @@ void main() {
                 error is RPCError &&
                 error.code == -32001 &&
                 error.details == jsonEncode(errorDetails))));
+      }, onPlatform: {
+        'windows': const Skip('https://github.com/dart-lang/webdev/issues/711'),
       });
     });
 

dwds/test/debug_service_test.dart

@@ -3,9 +3,6 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @TestOn('vm')
-@OnPlatform({
-  'windows': Skip('https://github.com/dart-lang/webdev/issues/711'),
-})
 import 'dart:io';
 
 import 'package:test/test.dart';

dwds/test/devtools_test.dart

@@ -4,9 +4,6 @@
 
 @Timeout(Duration(minutes: 5))
 @TestOn('vm')
-@OnPlatform({
-  'windows': Skip('https://github.com/dart-lang/webdev/issues/711'),
-})
 import 'package:test/test.dart';
 import 'package:webdriver/io.dart';
 

dwds/test/fixtures/context.dart

@@ -185,7 +185,11 @@ class TestContext {
         .any((result) => result.status == BuildStatus.succeeded));
 
     // Allow change to propagate to the browser.
-    await Future.delayed(const Duration(seconds: 2));
+    // Windows, or at least Travis on Windows, seems to need more time.
+    var delay = Platform.isWindows
+        ? const Duration(seconds: 5)
+        : const Duration(seconds: 2);
+    await Future.delayed(delay);
   }
 
   Future<ChromeTab> _fetchDartDebugExtensionTab(

dwds/test/refresh_test.dart

@@ -5,9 +5,6 @@
 /// Tests that require a fresh context to run, and can interfere with other
 /// tests.
 @TestOn('vm')
-@OnPlatform({
-  'windows': Skip('https://github.com/dart-lang/webdev/issues/711'),
-})
 library refresh_test;
 
 import 'dart:async';

dwds/test/reload_test.dart

@@ -4,9 +4,6 @@
 
 @TestOn('vm')
 @Timeout(Duration(minutes: 5))
-@OnPlatform({
-  'windows': Skip('https://github.com/dart-lang/webdev/issues/711'),
-})
 
 import 'package:dwds/dwds.dart';
 import 'package:test/test.dart';