Add and apply lints for imports (#1940)

Author: elliette

dwds/analysis_options.yaml

@@ -15,5 +15,7 @@ analyzer:
 
 linter:
   rules:
+    - always_use_package_imports
+    - directives_ordering
     - prefer_final_locals
     - unawaited_futures

dwds/debug_extension_mv3/web/background.dart

@@ -11,10 +11,10 @@ import 'dart:html';
 import 'package:dwds/data/debug_info.dart';
 import 'package:js/js.dart';
 
-import 'data_types.dart';
-import 'debug_session.dart';
 import 'chrome_api.dart';
 import 'cross_extension_communication.dart';
+import 'data_types.dart';
+import 'debug_session.dart';
 import 'lifeline_ports.dart';
 import 'logger.dart';
 import 'messaging.dart';

dwds/debug_extension_mv3/web/devtools.dart

@@ -6,8 +6,9 @@
 library devtools;
 
 import 'dart:html';
-import 'package:js/js.dart';
+
 import 'package:dwds/data/debug_info.dart';
+import 'package:js/js.dart';
 
 import 'chrome_api.dart';
 import 'logger.dart';

dwds/debug_extension_mv3/web/messaging.dart

@@ -9,8 +9,8 @@ import 'dart:convert';
 
 import 'package:js/js.dart';
 
-import 'data_serializers.dart';
 import 'chrome_api.dart';
+import 'data_serializers.dart';
 import 'logger.dart';
 
 enum Script {

dwds/debug_extension_mv3/web/web_api.dart

@@ -2,9 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 import 'dart:html';
+import 'dart:js_util' as js_util;
 
 import 'package:js/js.dart';
-import 'dart:js_util' as js_util;
 
 @JS()
 // ignore: non_constant_identifier_names

dwds/lib/dart_web_debug_service.dart

@@ -4,24 +4,23 @@
 
 import 'dart:async';
 
+import 'package:dwds/data/build_result.dart';
+import 'package:dwds/src/connections/app_connection.dart';
+import 'package:dwds/src/connections/debug_connection.dart';
+import 'package:dwds/src/events.dart';
+import 'package:dwds/src/handlers/dev_handler.dart';
+import 'package:dwds/src/handlers/injector.dart';
+import 'package:dwds/src/handlers/socket_connections.dart';
+import 'package:dwds/src/loaders/strategy.dart';
+import 'package:dwds/src/readers/asset_reader.dart';
+import 'package:dwds/src/servers/devtools.dart';
+import 'package:dwds/src/servers/extension_backend.dart';
+import 'package:dwds/src/services/expression_compiler.dart';
 import 'package:logging/logging.dart';
 import 'package:shelf/shelf.dart';
 import 'package:sse/server/sse_handler.dart';
 import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart';
 
-import 'data/build_result.dart';
-import 'src/connections/app_connection.dart';
-import 'src/connections/debug_connection.dart';
-import 'src/events.dart';
-import 'src/handlers/dev_handler.dart';
-import 'src/handlers/injector.dart';
-import 'src/handlers/socket_connections.dart';
-import 'src/loaders/strategy.dart';
-import 'src/readers/asset_reader.dart';
-import 'src/servers/devtools.dart';
-import 'src/servers/extension_backend.dart';
-import 'src/services/expression_compiler.dart';
-
 typedef ConnectionProvider = Future<ChromeConnection> Function();
 
 /// The Dart Web Debug Service.

dwds/lib/src/connections/app_connection.dart

@@ -5,10 +5,10 @@
 import 'dart:async';
 import 'dart:convert';
 
-import '../../data/connect_request.dart';
-import '../../data/run_request.dart';
-import '../../data/serializers.dart';
-import '../handlers/socket_connections.dart';
+import 'package:dwds/data/connect_request.dart';
+import 'package:dwds/data/run_request.dart';
+import 'package:dwds/data/serializers.dart';
+import 'package:dwds/src/handlers/socket_connections.dart';
 
 /// A connection between the application loaded in the browser and DWDS.
 class AppConnection {

dwds/lib/src/connections/debug_connection.dart

@@ -4,11 +4,10 @@
 
 import 'dart:async';
 
+import 'package:dwds/src/services/app_debug_services.dart';
+import 'package:dwds/src/services/chrome_proxy_service.dart';
 import 'package:vm_service/vm_service.dart';
 
-import '../services/app_debug_services.dart';
-import '../services/chrome_proxy_service.dart';
-
 /// A debug connection between the application in the browser and DWDS.
 ///
 /// Supports debugging your running application through the Dart VM Service

dwds/lib/src/debugging/classes.dart

@@ -2,15 +2,14 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.import 'dart:async';
 
+import 'package:dwds/src/debugging/metadata/class.dart';
+import 'package:dwds/src/loaders/strategy.dart';
+import 'package:dwds/src/services/chrome_debug_exception.dart';
+import 'package:dwds/src/utilities/domain.dart';
+import 'package:dwds/src/utilities/shared.dart';
 import 'package:vm_service/vm_service.dart';
 import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart';
 
-import '../../src/services/chrome_debug_exception.dart';
-import '../loaders/strategy.dart';
-import '../utilities/domain.dart';
-import '../utilities/shared.dart';
-import 'metadata/class.dart';
-
 /// Keeps track of Dart classes available in the running application.
 class ClassHelper extends Domain {
   /// Map of class ID to [Class].

dwds/lib/src/debugging/dart_scope.dart

@@ -2,11 +2,10 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:dwds/src/debugging/debugger.dart';
+import 'package:dwds/src/utilities/objects.dart';
 import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart';
 
-import '../utilities/objects.dart';
-import 'debugger.dart';
-
 // TODO(sdk/issues/44262) - use an alternative way to identify synthetic
 // variables.
 final ddcTemporaryVariableRegExp = RegExp(r'^(t[0-9]+\$?[0-9]*|__t[\$\w*]+)$');