Skip to content

Commit d585673

Browse files
committed
Handle new optional parameters of getInstances
1 parent f978b90 commit d585673

File tree

4 files changed

+13
-2
lines changed

4 files changed

+13
-2
lines changed

dwds/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
- Prepare for Dart 3 alpha breaking changes:
2121
- Generate missing SDK assets for tests.
2222
- Enable frontend server null safe tests.
23+
- Add optional `includeSubclasses` and `includeImplementers` parameters to
24+
`ChromeProxyService.getInstances()`.
2325

2426
**Breaking changes**
2527
- Include an optional param to `Dwds.start` to indicate whether it is running

dwds/lib/src/services/chrome_proxy_service.dart

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,12 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension(
562562

563563
@override
564564
Future<InstanceSet> getInstances(
565-
String isolateId, String classId, int limit) {
565+
String isolateId,
566+
String classId,
567+
int limit, {
568+
bool? includeSubclasses,
569+
bool? includeImplementers,
570+
}) {
566571
return _rpcNotSupportedFuture('getInstances');
567572
}
568573

dwds/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ dependencies:
3434
stack_trace: ^1.10.0
3535
sse: ^4.1.2
3636
uuid: ^3.0.6
37-
vm_service: ^9.0.0
37+
vm_service: ^10.1.0
3838
web_socket_channel: ^2.2.0
3939
webkit_inspection_protocol: ^1.0.1
4040

dwds/test/chrome_proxy_service_test.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -380,6 +380,10 @@ void main() {
380380

381381
test('getInstances', () async {
382382
await expectLater(service.getInstances('', '', 0), throwsRPCError);
383+
await expectLater(
384+
service.getInstances('', '', 0,
385+
includeImplementers: true, includeSubclasses: true),
386+
throwsRPCError);
383387
});
384388

385389
group('getIsolate', () {

0 commit comments

Comments
 (0)