Skip to content

Commit c77043e

Browse files
authored
[MV3 Debug Extension] Fix isDevMode getter (#1962)
1 parent a761125 commit c77043e

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

dwds/debug_extension_mv3/web/background.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,8 @@ void _setDebuggableIcon() {
142142
}
143143

144144
void _setDefaultIcon() {
145-
final iconPath = isDevMode()
146-
? 'static_assets/dart_dev.png'
147-
: 'static_assets/dart_grey.png';
145+
final iconPath =
146+
isDevMode ? 'static_assets/dart_dev.png' : 'static_assets/dart_grey.png';
148147
setExtensionIcon(IconInfo(path: iconPath));
149148
}
150149

dwds/debug_extension_mv3/web/devtools.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ void _maybeCreatePanels() async {
4444
if (!isInternalBuild) return;
4545
// Create a Debugger panel for all internal apps:
4646
chrome.devtools.panels.create(
47-
isDevMode() ? '[DEV] Dart Debugger' : 'Dart Debugger',
47+
isDevMode ? '[DEV] Dart Debugger' : 'Dart Debugger',
4848
'',
4949
'static_assets/debugger_panel.html',
5050
allowInterop((ExtensionPanel panel) => _onPanelAdded(panel, debugInfo)),
@@ -53,7 +53,7 @@ void _maybeCreatePanels() async {
5353
final isFlutterApp = debugInfo.isFlutterApp ?? false;
5454
if (isFlutterApp) {
5555
chrome.devtools.panels.create(
56-
isDevMode() ? '[DEV] Flutter Inspector' : 'Flutter Inspector',
56+
isDevMode ? '[DEV] Flutter Inspector' : 'Flutter Inspector',
5757
'',
5858
'static_assets/inspector_panel.html',
5959
allowInterop((ExtensionPanel panel) => _onPanelAdded(panel, debugInfo)),

dwds/debug_extension_mv3/web/logger.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ void _log(
4545
_LogLevel? level,
4646
String? prefix,
4747
}) {
48-
if (!verbose && !isDevMode()) return;
48+
if (!verbose && !isDevMode) return;
4949
final logMsg = prefix != null ? '[$prefix] $msg' : msg;
5050
final logLevel = level ?? _LogLevel.info;
5151
switch (logLevel) {

dwds/debug_extension_mv3/web/utils.dart

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,15 @@ void setExtensionIcon(IconInfo info) {
8686

8787
bool? _isDevMode;
8888

89-
bool isDevMode() {
89+
bool get isDevMode {
9090
if (_isDevMode != null) {
9191
return _isDevMode!;
9292
}
9393
final extensionManifest = chrome.runtime.getManifest();
9494
final extensionName = getProperty(extensionManifest, 'name') ?? '';
95-
return extensionName.contains('DEV');
95+
final isDevMode = extensionName.contains('DEV');
96+
_isDevMode = isDevMode;
97+
return isDevMode;
9698
}
9799

98100
String addQueryParameters(

0 commit comments

Comments
 (0)