Skip to content

Commit 433180a

Browse files
author
Anna Gringauze
committed
Address CR comments
1 parent 8b33827 commit 433180a

File tree

1 file changed

+22
-20
lines changed

1 file changed

+22
-20
lines changed

dwds/lib/src/dwds_vm_client.dart

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -152,34 +152,36 @@ void _processSendEvent(Map<String, dynamic> event,
152152
_logger.finest('Received DevTools event: $event');
153153
final action = payload?['action'] as String?;
154154
final screen = payload?['screen'] as String?;
155-
final devToolsStart = dwdsStats.devToolsStart;
156-
final debuggerStart = dwdsStats.debuggerStart;
157155
if (screen != null && action == 'pageReady') {
158-
if (dwdsStats.isFirstDebuggerReady) {
159-
if (devToolsStart != null) {
160-
final debuggerReadyTime =
161-
DateTime.now().difference(devToolsStart).inMilliseconds;
162-
emitEvent(DwdsEvent.devToolsLoad(debuggerReadyTime, screen));
163-
_logger.fine('DevTools load time: $debuggerReadyTime ms');
164-
}
165-
if (debuggerStart != null) {
166-
final debuggerStartTime =
167-
DateTime.now().difference(debuggerStart).inMilliseconds;
168-
emitEvent(DwdsEvent.debuggerReady(debuggerStartTime, screen));
169-
_logger.fine('Debugger ready time: $debuggerStartTime ms');
170-
}
171-
} else {
172-
_logger
173-
.finest('Debugger and DevTools startup times already recorded.'
174-
' Ignoring $event.');
175-
}
156+
_recordDwdsStats(dwdsStats, screen);
176157
} else {
177158
_logger.finest('Ignoring unknown event: $event');
178159
}
179160
}
180161
}
181162
}
182163

164+
void _recordDwdsStats(DwdsStats dwdsStats, String screen) {
165+
if (dwdsStats.isFirstDebuggerReady) {
166+
final devToolsStart = dwdsStats.devToolsStart;
167+
final debuggerStart = dwdsStats.debuggerStart;
168+
if (devToolsStart != null) {
169+
final devToolLoadTime =
170+
DateTime.now().difference(devToolsStart).inMilliseconds;
171+
emitEvent(DwdsEvent.devToolsLoad(devToolLoadTime, screen));
172+
_logger.fine('DevTools load time: $devToolLoadTime ms');
173+
}
174+
if (debuggerStart != null) {
175+
final debuggerReadyTime =
176+
DateTime.now().difference(debuggerStart).inMilliseconds;
177+
emitEvent(DwdsEvent.debuggerReady(debuggerReadyTime, screen));
178+
_logger.fine('Debugger ready time: $debuggerReadyTime ms');
179+
}
180+
} else {
181+
_logger.finest('Debugger and DevTools stats are already recorded.');
182+
}
183+
}
184+
183185
Future<Map<String, dynamic>> _hotRestart(
184186
ChromeProxyService chromeProxyService, VmService client) async {
185187
_logger.info('Attempting a hot restart');

0 commit comments

Comments
 (0)