Create test_common package (#1945)

* Validate only needed summaries in expression_compiler_service

* Move shared test functionality into test_common package

* Rebase on master

* Fix bad merge

* Add comments

* Run expression compiler service test with sound null safety

Author: Anna Gringauze

.github/workflows/dart.yml

@@ -10,6 +10,7 @@
   - Fill `BoundField.name` for records.
   - Display records as a container of fields.
 - Remove test-only code from `sdk_configuration.dart`.
+- Move shared test-only code to a new `test_common` package.
 
 **Breaking changes**
 - Require `sdkConfigurationProvider` in `ExpressionCompilerService`

dwds/CHANGELOG.md

@@ -55,4 +55,6 @@ dev_dependencies:
   puppeteer: ^2.19.0
   stream_channel: ^2.1.0
   test: ^1.21.1
+  test_common:
+    path: ../test_common
   webdriver: ^3.0.0

dwds/pubspec.yaml

@@ -9,11 +9,11 @@ import 'dart:async';
 import 'package:dwds/src/connections/debug_connection.dart';
 import 'package:dwds/src/services/chrome_proxy_service.dart';
 import 'package:test/test.dart';
+import 'package:test_common/logging.dart';
 import 'package:vm_service/vm_service.dart';
 import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart';
 
 import 'fixtures/context.dart';
-import 'fixtures/logging.dart';
 
 class TestSetup {
   static final contextUnsound = TestContext.withWeakNullSafety(

dwds/test/build_daemon_callstack_test.dart

@@ -16,11 +16,11 @@ import 'package:dwds/src/utilities/shared.dart';
 import 'package:http/http.dart' as http;
 import 'package:path/path.dart' as path;
 import 'package:test/test.dart';
+import 'package:test_common/logging.dart';
 import 'package:vm_service/vm_service.dart';
 import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart';
 
 import 'fixtures/context.dart';
-import 'fixtures/logging.dart';
 
 final context = TestContext.withSoundNullSafety();
 

dwds/test/chrome_proxy_service_test.dart

@@ -8,9 +8,9 @@
 import 'package:dwds/src/loaders/strategy.dart';
 import 'package:dwds/src/utilities/dart_uri.dart';
 import 'package:test/test.dart';
+import 'package:test_common/logging.dart';
 
 import 'fixtures/fakes.dart';
-import 'fixtures/logging.dart';
 
 class TestStrategy extends FakeStrategy {
   @override

dwds/test/dart_uri_test.dart

@@ -9,11 +9,11 @@ import 'dart:async';
 import 'package:dwds/src/connections/debug_connection.dart';
 import 'package:dwds/src/services/chrome_proxy_service.dart';
 import 'package:test/test.dart';
+import 'package:test_common/logging.dart';
 import 'package:vm_service/vm_service.dart';
 import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart';
 
 import 'fixtures/context.dart';
-import 'fixtures/logging.dart';
 
 class TestSetup {
   static TestContext contextUnsound(String index) =>

dwds/test/evaluate_circular_common.dart

@@ -9,11 +9,11 @@ import 'dart:async';
 import 'package:dwds/src/connections/debug_connection.dart';
 import 'package:dwds/src/services/chrome_proxy_service.dart';
 import 'package:test/test.dart';
+import 'package:test_common/logging.dart';
 import 'package:vm_service/vm_service.dart';
 import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart';
 
 import 'fixtures/context.dart';
-import 'fixtures/logging.dart';
 
 class TestSetup {
   static TestContext contextUnsound(String index) =>

dwds/test/evaluate_common.dart

@@ -11,12 +11,12 @@ import 'package:dwds/src/events.dart';
 import 'package:dwds/src/services/chrome_proxy_service.dart';
 import 'package:dwds/src/utilities/server.dart';
 import 'package:test/test.dart';
+import 'package:test_common/logging.dart';
 import 'package:vm_service/vm_service.dart';
 import 'package:webdriver/async_core.dart';
 import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart';
 
 import 'fixtures/context.dart';
-import 'fixtures/logging.dart';
 
 ChromeProxyService get service =>
     fetchChromeProxyService(context.debugConnection);

dwds/test/events_test.dart

@@ -9,14 +9,13 @@ import 'dart:convert';
 import 'dart:io';
 
 import 'package:dwds/expression_compiler.dart';
+import 'package:dwds/sdk_configuration.dart';
 import 'package:dwds/src/services/expression_compiler_service.dart';
-import 'package:dwds/src/utilities/sdk_configuration.dart';
 import 'package:dwds/src/utilities/server.dart';
 import 'package:logging/logging.dart';
 import 'package:shelf/shelf.dart';
 import 'package:test/test.dart';
-
-import 'fixtures/logging.dart';
+import 'package:test_common/logging.dart';
 
 ExpressionCompilerService get service => _service!;
 late ExpressionCompilerService? _service;
@@ -47,10 +46,12 @@ void main() async {
       final source = outputDir.uri.resolve('try.dart');
       final packages = outputDir.uri.resolve('package_config.json');
       final kernel = outputDir.uri.resolve('try.full.dill');
+      // Expression compiler service does not need any extra assets
+      // generated in the SDK, so we use the current SDK layout and
+      // configuration.
       final executable = Platform.resolvedExecutable;
       final dartdevc =
           SdkConfiguration.defaultConfiguration.compilerWorkerPath!;
-
       // redirect logs for testing
       _output = StreamController<String>.broadcast();
       output.stream.listen(printOnFailure);
@@ -76,7 +77,7 @@ void main() async {
         sdkConfigurationProvider: DefaultSdkConfigurationProvider(),
       );
 
-      await service.initialize(moduleFormat: 'amd');
+      await service.initialize(moduleFormat: 'amd', soundNullSafety: true);
 
       // setup asset server
       serveHttpRequests(server, assetHandler, (e, s) {