Remove ChromeProxyService.setExceptionPauseMode() (#1820)

* Remove ChromeProxyService.setExceptionPauseMode()

* Add missing line from "break on exceptions with setIsolatePauseMode" test

* Add test that doesn't supply any optional arguments to setIsolatePauseMode()

Author: derekxu16

dwds/CHANGELOG.md

@@ -12,6 +12,7 @@
 - Include an optional param to `Dwds.start` to indicate whether it a Flutter app
   or not.
 - Pre-warm expression compiler cache to speed up Flutter Inspector loading.
+- Remove `ChromeProxyService.setExceptionPauseMode()`.
 
 ## 16.0.1
 

dwds/lib/src/services/chrome_proxy_service.dart

@@ -776,15 +776,10 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension(
       {String? exceptionPauseMode, bool? shouldPauseOnExit}) async {
     // TODO(elliette): Is there a way to respect the shouldPauseOnExit parameter
     // in Chrome?
-    return setExceptionPauseMode(
-        isolateId, exceptionPauseMode ?? ExceptionPauseMode.kNone);
-  }
-
-  @override
-  Future<Success> setExceptionPauseMode(String isolateId, String mode) async {
     await isInitialized;
-    _checkIsolate('setExceptionPauseMode', isolateId);
-    return (await debuggerFuture).setExceptionPauseMode(mode);
+    _checkIsolate('setIsolatePauseMode', isolateId);
+    return (await debuggerFuture)
+        .setExceptionPauseMode(exceptionPauseMode ?? ExceptionPauseMode.kNone);
   }
 
   @override

dwds/test/chrome_proxy_service_test.dart

@@ -1104,26 +1104,6 @@ void main() {
         expect(stack.truncated, isFalse);
       });
 
-      test('break on exceptions with legacy setExceptionPauseMode', () async {
-        final oldPauseMode =
-            (await service.getIsolate(isolateId!)).exceptionPauseMode!;
-        await service.setExceptionPauseMode(
-            isolateId!, ExceptionPauseMode.kAll);
-        // Wait for pausing to actually propagate.
-        final event = await stream
-            .firstWhere((event) => event.kind == EventKind.kPauseException);
-        expect(event.exception, isNotNull);
-        // Check that the exception stack trace has been mapped to Dart source files.
-        // TODO(https://github.com/dart-lang/webdev/issues/1821) Uncomment.
-        // expect(event.exception!.valueAsString, contains('main.dart'));
-
-        final stack = await service.getStack(isolateId!);
-        expect(stack, isNotNull);
-
-        await service.setExceptionPauseMode(isolateId!, oldPauseMode);
-        await service.resume(isolateId!);
-      });
-
       test('break on exceptions with setIsolatePauseMode', () async {
         final oldPauseMode =
             (await service.getIsolate(isolateId!)).exceptionPauseMode;
@@ -1133,6 +1113,9 @@ void main() {
         final event = await stream
             .firstWhere((event) => event.kind == EventKind.kPauseException);
         expect(event.exception, isNotNull);
+        // Check that the exception stack trace has been mapped to Dart source files.
+        // TODO(https://github.com/dart-lang/webdev/issues/1821) Uncomment.
+        // expect(event.exception!.valueAsString, contains('main.dart'));
 
         final stack = await service.getStack(isolateId!);
         expect(stack, isNotNull);
@@ -1462,17 +1445,26 @@ void main() {
       await expectLater(service.reloadSources(''), throwsRPCError);
     });
 
-    test('setExceptionPauseMode', () async {
+    test('setIsolatePauseMode', () async {
       final vm = await service.getVM();
       final isolateId = vm.isolates!.first.id!;
-      expect(await service.setExceptionPauseMode(isolateId, 'all'), _isSuccess);
-      expect(await service.setExceptionPauseMode(isolateId, 'unhandled'),
+      expect(await service.setIsolatePauseMode(isolateId), _isSuccess);
+      expect(
+          await service.setIsolatePauseMode(isolateId,
+              exceptionPauseMode: ExceptionPauseMode.kAll),
+          _isSuccess);
+      expect(
+          await service.setIsolatePauseMode(isolateId,
+              exceptionPauseMode: ExceptionPauseMode.kUnhandled),
           _isSuccess);
       // Make sure this is the last one - or future tests might hang.
       expect(
-          await service.setExceptionPauseMode(isolateId, 'none'), _isSuccess);
+          await service.setIsolatePauseMode(isolateId,
+              exceptionPauseMode: ExceptionPauseMode.kNone),
+          _isSuccess);
       await expectLater(
-          service.setExceptionPauseMode(isolateId, 'invalid'), throwsRPCError);
+          service.setIsolatePauseMode(isolateId, exceptionPauseMode: 'invalid'),
+          throwsRPCError);
     });
 
     test('setFlag', () async {