Update to latest lints, Require Dart 3.2 (dart-archive/package_config#145)

Author: kevmoo

pkgs/package_config/.github/workflows/test-package.yml

@@ -47,7 +47,7 @@ jobs:
       matrix:
         # Add macos-latest and/or windows-latest if relevant for this package.
         os: [ubuntu-latest]
-        sdk: [3.0.0, dev]
+        sdk: [3.2, dev]
     steps:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
       - uses: dart-lang/setup-dart@b64355ae6ca0b5d484f0106a033dd1388965d06d

pkgs/package_config/CHANGELOG.md

@@ -1,6 +1,6 @@
 ## 2.1.1-wip
 
-- Require Dart 3.0
+- Require Dart 3.2
 
 ## 2.1.0
 

pkgs/package_config/lib/package_config.dart

@@ -102,7 +102,7 @@ Future<PackageConfig> loadPackageConfigUri(Uri file,
 /// then the parent directories are checked recursively,
 /// all the way to the root directory, to check if those contains
 /// a package configuration.
-/// If [recurse] is set to [false], this parent directory check is not
+/// If [recurse] is set to `false`, this parent directory check is not
 /// performed.
 ///
 /// If [onError] is provided, the configuration file parsing will report errors
@@ -140,7 +140,7 @@ Future<PackageConfig?> findPackageConfig(Directory directory,
 /// then the parent directories are checked recursively,
 /// all the way to the root directory, to check if those contains
 /// a package configuration.
-/// If [recurse] is set to [false], this parent directory check is not
+/// If [recurse] is set to `false`, this parent directory check is not
 /// performed.
 ///
 /// If [loader] is provided, URIs are loaded using that function.

pkgs/package_config/lib/src/errors.dart

@@ -12,17 +12,18 @@ abstract class PackageConfigError {
 
 class PackageConfigArgumentError extends ArgumentError
     implements PackageConfigError {
-  PackageConfigArgumentError(Object? value, String name, String message)
-      : super.value(value, name, message);
+  PackageConfigArgumentError(
+      Object? super.value, String super.name, String super.message)
+      : super.value();
 
   PackageConfigArgumentError.from(ArgumentError error)
       : super.value(error.invalidValue, error.name, error.message);
 }
 
 class PackageConfigFormatException extends FormatException
     implements PackageConfigError {
-  PackageConfigFormatException(String message, Object? source, [int? offset])
-      : super(message, source, offset);
+  PackageConfigFormatException(super.message, Object? super.source,
+      [super.offset]);
 
   PackageConfigFormatException.from(FormatException exception)
       : super(exception.message, exception.source, exception.offset);

pkgs/package_config/lib/src/package_config.dart

@@ -32,7 +32,7 @@ abstract class PackageConfig {
   /// absolute directory URIs, valid language version, if any),
   /// and there must not be two packages with the same name.
   ///
-  /// The package's root ([Package.rootUri]) and package-root
+  /// The package's root ([Package.root]) and package-root
   /// ([Package.packageUriRoot]) paths must satisfy a number of constraints
   /// We say that one path (which we know ends with a `/` charater)
   /// is inside another path, if the latter path is a prefix of the former path,
@@ -95,7 +95,7 @@ abstract class PackageConfig {
 
   /// Parses the JSON data of a package configuration file.
   ///
-  /// The [configuration] must be a JSON-like Dart data structure,
+  /// The [jsonData] must be a JSON-like Dart data structure,
   /// like the one provided by parsing JSON text using `dart:convert`,
   /// containing a valid package configuration.
   ///
@@ -167,7 +167,7 @@ abstract class PackageConfig {
   /// Provides the associated package for a specific [file] (or directory).
   ///
   /// Returns a [Package] which contains the [file]'s path, if any.
-  /// That is, the [Package.rootUri] directory is a parent directory
+  /// That is, the [Package.root] directory is a parent directory
   /// of the [file]'s location.
   ///
   /// Returns `null` if the file does not belong to any package.
@@ -247,7 +247,7 @@ abstract class Package {
   /// Is always an absolute URI with no query or fragment parts,
   /// and with a path ending in `/`.
   ///
-  /// All files in the [rootUri] directory are considered
+  /// All files in the [root] directory are considered
   /// part of the package for purposes where that that matters.
   Uri get root;
 

pkgs/package_config/lib/src/package_config_impl.dart

@@ -141,12 +141,6 @@ class SimplePackageConfig implements PackageConfig {
   @override
   Package? operator [](String packageName) => _packages[packageName];
 
-  /// Provides the associated package for a specific [file] (or directory).
-  ///
-  /// Returns a [Package] which contains the [file]'s path.
-  /// That is, the [Package.rootUri] directory is a parent directory
-  /// of the [file]'s location.
-  /// Returns `null` if the file does not belong to any package.
   @override
   Package? packageOf(Uri file) => _packageTree.packageOf(file);
 
@@ -270,7 +264,7 @@ class SimplePackage implements Package {
   }
 }
 
-/// Checks whether [version] is a valid Dart language version string.
+/// Checks whether [source] is a valid Dart language version string.
 ///
 /// The format is (as RegExp) `^(0|[1-9]\d+)\.(0|[1-9]\d+)$`.
 ///
@@ -553,9 +547,8 @@ enum ConflictType { sameRoots, interleaving, insidePackageRoot }
 /// Conflict between packages added to the same configuration.
 ///
 /// The [package] conflicts with [existingPackage] if it has
-/// the same root path ([isRootConflict]) or the package URI root path
-/// of [existingPackage] is inside the root path of [package]
-/// ([isPackageRootConflict]).
+/// the same root path or the package URI root path
+/// of [existingPackage] is inside the root path of [package].
 class ConflictException {
   /// The existing package that [package] conflicts with.
   final SimplePackage existingPackage;

pkgs/package_config/lib/src/package_config_io.dart

@@ -38,7 +38,7 @@ const packagesFileName = '.packages';
 /// If the [file] is a `.packages` file and [preferNewest] is true,
 /// first checks whether there is an adjacent `.dart_tool/package_config.json`
 /// file, and if so, reads that instead.
-/// If [preferNewset] is false, the specified file is loaded even if it is
+/// If [preferNewest] is false, the specified file is loaded even if it is
 /// a `.packages` file and there is an available `package_config.json` file.
 ///
 /// The file must exist and be a normal file.

pkgs/package_config/lib/src/package_config_json.dart

@@ -75,10 +75,8 @@ PackageConfig parsePackageConfigString(
 ///     where the integer numeral cannot have a sign, and can only have a
 ///     leading zero if the entire numeral is a single zero.
 ///
-/// All other properties are stored in [extraData].
-///
 /// The [baseLocation] is used as base URI to resolve the "rootUri"
-/// URI referencestring.
+/// URI reference string.
 PackageConfig parsePackageConfigJson(
     Object? json, Uri baseLocation, void Function(Object error) onError) {
   if (!baseLocation.hasScheme || baseLocation.isScheme('package')) {
@@ -93,7 +91,7 @@ PackageConfig parsePackageConfigJson(
   String typeName<T>() {
     if (0 is T) return 'int';
     if ('' is T) return 'string';
-    if (const [] is T) return 'array';
+    if (const <Object?>[] is T) return 'array';
     return 'object';
   }
 
@@ -239,7 +237,7 @@ void writePackageConfigJsonString(
     PackageConfig config, Uri? baseUri, StringSink output) {
   // Can be optimized.
   var data = packageConfigToJson(config, baseUri);
-  output.write(JsonEncoder.withIndent('  ').convert(data));
+  output.write(const JsonEncoder.withIndent('  ').convert(data));
 }
 
 Map<String, Object?> packageConfigToJson(PackageConfig config, Uri? baseUri) =>

pkgs/package_config/lib/src/packages_file.dart

@@ -148,12 +148,6 @@ PackageConfig parse(
 ///
 /// If [baseUri] is provided, package locations will be made relative
 /// to the base URI, if possible, before writing.
-///
-/// If [allowDefaultPackage] is `true`, the [packageMapping] may contain an
-/// empty string mapping to the _default package name_.
-///
-/// All the keys of [packageMapping] must be valid package names,
-/// and the values must be URIs that do not have the `package:` scheme.
 void write(StringSink output, PackageConfig config,
     {Uri? baseUri, String? comment}) {
   if (baseUri != null && !baseUri.isAbsolute) {

pkgs/package_config/pubspec.yaml

@@ -4,7 +4,7 @@ description: Support for reading and writing Dart Package Configuration files.
 repository: https://github.com/dart-lang/package_config
 
 environment:
-  sdk: ^3.0.0
+  sdk: ^3.2.0
 
 dependencies:
   path: ^1.8.0
@@ -13,5 +13,5 @@ dev_dependencies:
   build_runner: ^2.0.0
   build_test: ^2.1.2
   build_web_compilers: ^4.0.0
-  dart_flutter_team_lints: ^1.0.0
+  dart_flutter_team_lints: ^2.0.0
   test: ^1.16.0