Skip to content

Commit 3bdbced

Browse files
stereotype441Commit Queue
authored andcommitted
Revert "[analyzer] Add experimental_member_use warning."
This reverts commit 3923958. Reason for revert: Broke dart->flutter roll flutter/flutter#176234 due to customer testing Original change's description: > [analyzer] Add experimental_member_use warning. > > Adds the implementation of the `experimental_member_use` warning > (whose diagnostic code was introduced in > https://dart-review.googlesource.com/c/sdk/+/451341). > > There is very little implementation logic, since the bulk of the > implementation is shared with the existing `deprecated_member_use` > warning. Unit tests are adapted from the `deprecated_member_use` unit > tests. > > Since the tests in `non_const_argument_for_const_parameter_test.dart` > use the annotation `@mustBeConst`, which is marked `@experimental`, > they had to be modified to expect the new warning. > > Change-Id: I6a6a69645bb072b29166b7617b480a890b2bb5aa > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/450970 > Reviewed-by: Samuel Rawlins <[email protected]> > Commit-Queue: Paul Berry <[email protected]> Change-Id: I6a6a696447ed61b133e17ffc63ca6067fdbcc1ca Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/452526 Commit-Queue: Paul Berry <[email protected]> Reviewed-by: Alexander Aprelev <[email protected]> Reviewed-by: Samuel Rawlins <[email protected]>
1 parent acd7ee0 commit 3bdbced

File tree

12 files changed

+71
-2979
lines changed

12 files changed

+71
-2979
lines changed

pkg/analysis_server_plugin/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ resolution: workspace
1111
dependencies:
1212
# See the release policy for managing this dependency at
1313
# pkg/analyzer/doc/implementation/releasing.md.
14-
analyzer: 8.3.0-dev
14+
analyzer: 8.2.0
1515
analyzer_plugin: 0.13.8
1616
meta: ^1.16.0
1717
yaml: ^3.1.0

pkg/analyzer/CHANGELOG.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
## 8.3.0-dev
2-
* Add the `experimental_member_use` warning, which warns about any reference to
3-
a declaration annotated with `@experimental`.
4-
51
## 8.2.0
62
* Updated SDK constraint to `^3.9.0`.
73
* Deprecate `Diagnostic.data`. Instead, please use an expando to attach data to

pkg/analyzer/lib/src/error/best_practices_verifier.dart

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ import 'package:analyzer/src/error/deprecated_member_use_verifier.dart';
3333
import 'package:analyzer/src/error/doc_comment_verifier.dart';
3434
import 'package:analyzer/src/error/element_usage_frontier_detector.dart';
3535
import 'package:analyzer/src/error/error_handler_verifier.dart';
36-
import 'package:analyzer/src/error/experimental_member_use_verifier.dart';
3736
import 'package:analyzer/src/error/must_call_super_verifier.dart';
3837
import 'package:analyzer/src/error/null_safe_api_verifier.dart';
3938
import 'package:analyzer/src/error/widget_preview_verifier.dart';
@@ -124,13 +123,6 @@ class BestPracticesVerifier extends RecursiveAstVisitor<void> {
124123
diagnosticReporter: _diagnosticReporter,
125124
),
126125
),
127-
ElementUsageFrontierDetector(
128-
workspacePackage: workspacePackage,
129-
elementUsageSet: const ExperimentalElementUsageSet(),
130-
elementUsageReporter: ExperimentalElementUsageReporter(
131-
diagnosticReporter: _diagnosticReporter,
132-
),
133-
),
134126
],
135127
_errorHandlerVerifier = ErrorHandlerVerifier(
136128
_diagnosticReporter,

pkg/analyzer/lib/src/error/experimental_member_use_verifier.dart

Lines changed: 0 additions & 45 deletions
This file was deleted.

pkg/analyzer/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: analyzer
2-
version: 8.3.0-dev
2+
version: 8.2.0
33
description: >-
44
This package provides a library that performs static analysis of Dart code.
55
repository: https://github.com/dart-lang/sdk/tree/main/pkg/analyzer

0 commit comments

Comments
 (0)