Deprecate PartDirective.configurations

Change-Id: I6e9757e531e2f9f46da5bb78ffef7cf694cf7467
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/454321
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analysis_server_plugin/lib/src/utilities/selection.dart

@@ -270,7 +270,7 @@ class _ChildrenFinder extends SimpleAstVisitor<void> {
 
   @override
   void visitPartDirective(PartDirective node) {
-    _fromList(node.metadata) || _fromList(node.configurations);
+    _fromList(node.metadata);
   }
 
   @override

pkg/analyzer/CHANGELOG.md

@@ -1,6 +1,7 @@
 ## 8.3.0
 * Deprecate `TypeDefiningElement`, check for specific elements.
 * Deprecate `TypeDefiningFragment`, check for specific fragments.
+* Deprecate `PartDirective.configurations`, removed from the specification.
 
 ## 8.2.0
 * Updated SDK constraint to `^3.9.0`.

pkg/analyzer/api.txt

@@ -1504,7 +1504,7 @@ package:analyzer/dart/ast/ast.dart:
     pattern (getter: DartPattern)
     rightParenthesis (getter: Token)
   PartDirective (class extends Object implements UriBasedDirective):
-    configurations (getter: NodeList<Configuration>)
+    configurations (getter: NodeList<Configuration>, deprecated)
     partInclude (getter: PartInclude?)
     partKeyword (getter: Token)
     semicolon (getter: Token)

pkg/analyzer/lib/src/dart/analysis/file_state.dart

@@ -1160,7 +1160,7 @@ class FileState {
 
   static UnlinkedPartDirective _serializePart(PartDirective node) {
     return UnlinkedPartDirective(
-      configurations: _serializeConfigurations(node.configurations),
+      configurations: [],
       partKeywordOffset: node.partKeyword.offset,
       uri: node.uri.stringValue,
     );

pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart

@@ -1076,7 +1076,7 @@ class LibraryAnalyzer {
 
     if (directive != null) {
       _resolveUriConfigurations(
-        configurationNodes: directive.configurations,
+        configurationNodes: [],
         configurationUris: partState.uris.configurations,
       );
     }

pkg/analyzer/lib/src/dart/ast/ast.dart

@@ -18179,6 +18179,7 @@ final class ParenthesizedPatternImpl extends DartPatternImpl
 @AnalyzerPublicApi(message: 'exported by lib/dart/ast/ast.dart')
 abstract final class PartDirective implements UriBasedDirective {
   /// The configurations that control which file is actually included.
+  @Deprecated('Removed from the specification')
   NodeList<Configuration> get configurations;
 
   /// Information about this part directive.
@@ -18197,7 +18198,6 @@ abstract final class PartDirective implements UriBasedDirective {
   childEntitiesOrder: [
     GenerateNodeProperty('partKeyword'),
     GenerateNodeProperty('uri', isSuper: true),
-    GenerateNodeProperty('configurations'),
     GenerateNodeProperty('semicolon'),
   ],
 )
@@ -18207,10 +18207,6 @@ final class PartDirectiveImpl extends UriBasedDirectiveImpl
   @override
   final Token partKeyword;
 
-  @generated
-  @override
-  final NodeListImpl<ConfigurationImpl> configurations = NodeListImpl._();
-
   @generated
   @override
   final Token semicolon;
@@ -18225,8 +18221,12 @@ final class PartDirectiveImpl extends UriBasedDirectiveImpl
     required this.partKeyword,
     required super.uri,
     required this.semicolon,
-  }) {
-    configurations._initialize(this, null);
+  });
+
+  @Deprecated('Removed from the specification')
+  @override
+  NodeListImpl<ConfigurationImpl> get configurations {
+    return NodeListImpl._().._initialize(this, null);
   }
 
   @generated
@@ -18246,7 +18246,6 @@ final class PartDirectiveImpl extends UriBasedDirectiveImpl
   ChildEntities get _childEntities => super._childEntities
     ..addToken('partKeyword', partKeyword)
     ..addNode('uri', uri)
-    ..addNodeList('configurations', configurations)
     ..addToken('semicolon', semicolon);
 
   @generated
@@ -18258,7 +18257,6 @@ final class PartDirectiveImpl extends UriBasedDirectiveImpl
   void visitChildren(AstVisitor visitor) {
     super.visitChildren(visitor);
     uri.accept(visitor);
-    configurations.accept(visitor);
   }
 
   @generated
@@ -18270,10 +18268,6 @@ final class PartDirectiveImpl extends UriBasedDirectiveImpl
     if (uri._containsOffset(rangeOffset, rangeEnd)) {
       return uri;
     }
-    if (configurations._elementContainingRange(rangeOffset, rangeEnd)
-        case var result?) {
-      return result;
-    }
     return null;
   }
 }

pkg/analyzer/lib/src/dart/ast/to_source_visitor.dart

@@ -1026,7 +1026,6 @@ class ToSourceVisitor implements AstVisitor<void> {
     _visitNodeList(node.metadata, separator: ' ', suffix: ' ');
     sink.write('part ');
     _visitNode(node.uri);
-    _visitNodeList(node.configurations, prefix: ' ', separator: ' ');
     sink.write(';');
   }