Skip to content

Commit bd403d2

Browse files
committed
move test to version_solver_test.dart
1 parent 8d8d622 commit bd403d2

File tree

2 files changed

+14
-27
lines changed

2 files changed

+14
-27
lines changed

test/dependency_services/dependency_services_test.dart

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -661,33 +661,6 @@ Future<void> main() async {
661661
environment: {'_PUB_TEST_SDK_VERSION': '3.5.0'},
662662
);
663663
});
664-
665-
testWithGolden('updates suppressed by prerelease dependency', (
666-
context,
667-
) async {
668-
final server = await servePackages();
669-
server.serve('foo', '1.0.0', deps: {'baz': '^1.0.0'});
670-
server.serve('foo', '2.0.0-dev.0', deps: {'baz': '^2.0.0'});
671-
server.serve('bar', '1.0.0', deps: {'baz': '^1.0.0'});
672-
server.serve('bar', '2.0.0', deps: {'baz': '^2.0.0'});
673-
server.serve('baz', '1.0.0');
674-
server.serve('baz', '2.0.0');
675-
676-
await d.appDir(dependencies: {'foo': '1.0.0', 'bar': '1.0.0'}).create();
677-
await pubGet();
678-
679-
await _reportWithForbidden(
680-
context,
681-
{},
682-
targetPackage: 'riverpod_lint',
683-
resultAssertions: (report) {
684-
expect(
685-
dig<List>(report, ['dependencies', ('name', 'foo'), 'multiBreaking']),
686-
isEmpty,
687-
);
688-
},
689-
);
690-
});
691664
}
692665

693666
String? findChangeVersion(dynamic json, String updateType, String name) {

test/version_solver_test.dart

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1666,6 +1666,20 @@ void prerelease() {
16661666
await d.appDir(dependencies: {'a': '^1.0.0'}).create();
16671667
await expectResolves(tries: 2);
16681668
});
1669+
1670+
// This is a regression test for #4659.
1671+
test('not upgrading to prerelease when constrained to stable', () async {
1672+
await servePackages()
1673+
..serve('a', '1.0.0', deps: {'c': '^1.0.0'})
1674+
..serve('b', '1.0.0', deps: {'c': '^1.0.0'})
1675+
..serve('c', '1.0.0')
1676+
..serve('a', '2.0.0', deps: {'c': '^2.0.0'})
1677+
..serve('b', '2.0.0-dev', deps: {'c': '^2.0.0'})
1678+
..serve('c', '2.0.0');
1679+
1680+
await d.appDir(dependencies: {'a': '^1.0.0', 'b': '^1.0.0'}).create();
1681+
await expectResolves(result: {'a': '1.0.0', 'b': '1.0.0', 'c': '1.0.0'});
1682+
});
16691683
}
16701684

16711685
void override() {

0 commit comments

Comments
 (0)