Remove warning

Author: srawlins

lib/src/model/model_element.dart

@@ -539,20 +539,6 @@ abstract class ModelElement extends Canonicalization
       return topLevelElement == lookup;
     }).toList(growable: true);
 
-    // Avoid claiming canonicalization for elements outside of this element's
-    // defining package.
-    // TODO(srawlins): Make the else block unconditional, so that we always
-    // exclude cross-package exports.
-    if (candidateLibraries.isNotEmpty &&
-        candidateLibraries.any((l) => l.package != definingLibrary.package)) {
-      warn(PackageWarning.reexportedPrivateApiAcrossPackages,
-          message: definingLibrary.package.fullyQualifiedName,
-          referredFrom: candidateLibraries);
-    } else {
-      candidateLibraries
-          .removeWhere((l) => l.package != definingLibrary.package);
-    }
-
     if (candidateLibraries.isEmpty) {
       return null;
     }

lib/src/model/package_graph.dart

@@ -353,7 +353,6 @@ class PackageGraph with CommentReferable, Nameable, ModelBuilder {
       PackageWarning.ambiguousDocReference ||
       PackageWarning.ignoredCanonicalFor ||
       PackageWarning.packageOrderGivesMissingPackageName ||
-      PackageWarning.reexportedPrivateApiAcrossPackages ||
       PackageWarning.notImplemented ||
       PackageWarning.unresolvedDocReference ||
       PackageWarning.unknownDirective ||

lib/src/warnings.dart

@@ -206,10 +206,6 @@ const Map<PackageWarning, PackageWarningDefinition> packageWarningDefinitions =
       PackageWarning.packageOrderGivesMissingPackageName,
       'category-order-gives-missing-package-name',
       'The category-order flag on the command line was given the name of a nonexistent package'),
-  PackageWarning.reexportedPrivateApiAcrossPackages: PackageWarningDefinition(
-      PackageWarning.reexportedPrivateApiAcrossPackages,
-      'reexported-private-api-across-packages',
-      'One or more libraries reexports private API members from outside its own package'),
   PackageWarning.unresolvedDocReference: PackageWarningDefinition(
       PackageWarning.unresolvedDocReference,
       'unresolved-doc-reference',
@@ -339,8 +335,6 @@ enum PackageWarning {
   noLibraryLevelDocs('{0} has no library level documentation comments'),
   packageOrderGivesMissingPackageName(
       "--package-order gives invalid package name: '{0}'"),
-  reexportedPrivateApiAcrossPackages(
-      'private API of {0} is reexported by libraries in other packages: '),
   unresolvedDocReference('unresolved doc reference [{0}]',
       referredFromPrefix: 'in documentation inherited from'),
   unknownDirective('undefined directive: {0}'),