Remove cross-export warning.

Author: srawlins

lib/src/model/model_element.dart

@@ -518,19 +518,6 @@ abstract class ModelElement
           (lookup is PropertyAccessorElement ? lookup.variable2 : lookup);
     }).toList(growable: true);
 
-    // Avoid claiming canonicalization for elements outside of this element's
-    // defining package.
-    // TODO(jcollins-g): Make the else block unconditional.
-    if (candidateLibraries.isNotEmpty &&
-        !candidateLibraries.any((l) => l.package == definingLibrary.package)) {
-      warn(PackageWarning.reexportedPrivateApiAcrossPackages,
-          message: definingLibrary.package.fullyQualifiedName,
-          referredFrom: candidateLibraries);
-    } else {
-      candidateLibraries
-          .removeWhere((l) => l.package != definingLibrary.package);
-    }
-
     if (candidateLibraries.isEmpty) {
       return null;
     }

lib/src/model/package_graph.dart

@@ -475,7 +475,6 @@ class PackageGraph with CommentReferable, Nameable {
       PackageWarning.ambiguousDocReference ||
       PackageWarning.ignoredCanonicalFor ||
       PackageWarning.packageOrderGivesMissingPackageName ||
-      PackageWarning.reexportedPrivateApiAcrossPackages ||
       PackageWarning.unresolvedDocReference ||
       PackageWarning.unknownMacro ||
       PackageWarning.unknownHtmlFragment ||

lib/src/warnings.dart

@@ -181,13 +181,6 @@ enum PackageWarning implements Comparable<PackageWarning> {
         'The category-order flag on the command line was given the name of a '
         'nonexistent package',
   ),
-  reexportedPrivateApiAcrossPackages(
-    'reexported-private-api-across-packages',
-    'private API of {0} is reexported by libraries in other packages: ',
-    shortHelp:
-        'One or more libraries reexports private API members from outside its '
-        'own package',
-  ),
   unresolvedDocReference(
     'unresolved-doc-reference',
     'unresolved doc reference [{0}]',