Skip to content

Commit 291841a

Browse files
committed
chore: Use latest durabletask-java version
Signed-off-by: Javier Aliaga <[email protected]>
1 parent a347929 commit 291841a

File tree

8 files changed

+22
-17
lines changed

8 files changed

+22
-17
lines changed

sdk-tests/src/test/java/io/dapr/it/testcontainers/workflows/DaprWorkflowsIT.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
import com.fasterxml.jackson.core.JsonProcessingException;
1717
import com.fasterxml.jackson.databind.ObjectMapper;
1818

19-
import io.dapr.it.testcontainers.KeyStore;
20-
import io.dapr.it.testcontainers.TestExecutionKeysWorkflow;
2119
import io.dapr.testcontainers.Component;
2220
import io.dapr.testcontainers.DaprContainer;
2321
import io.dapr.testcontainers.DaprLogLevel;
@@ -157,7 +155,7 @@ public void testNamedActivitiesWorkflows() throws Exception {
157155
String instanceId = workflowClient.scheduleNewWorkflow(TestNamedActivitiesWorkflow.class, payload);
158156

159157
workflowClient.waitForInstanceStart(instanceId, Duration.ofSeconds(10), false);
160-
158+
161159
Duration timeout = Duration.ofSeconds(10);
162160
WorkflowInstanceStatus workflowStatus = workflowClient.waitForInstanceCompletion(instanceId, timeout, true);
163161

@@ -175,6 +173,7 @@ public void testNamedActivitiesWorkflows() throws Exception {
175173
assertEquals(instanceId, workflowOutput.getWorkflowId());
176174
}
177175

176+
@Test
178177
public void testExecutionKeyWorkflows() throws Exception {
179178
TestWorkflowPayload payload = new TestWorkflowPayload(new ArrayList<>());
180179
String instanceId = workflowClient.scheduleNewWorkflow(TestExecutionKeysWorkflow.class, payload);
@@ -191,8 +190,7 @@ public void testExecutionKeyWorkflows() throws Exception {
191190
assertEquals(1, workflowOutput.getPayloads().size());
192191
assertEquals("Execution key found", workflowOutput.getPayloads().get(0));
193192

194-
String executionKey = workflowOutput.getWorkflowId() +"-"+"io.dapr.it.testcontainers.TaskExecutionKeyActivity";
195-
assertTrue(KeyStore.getInstance().getKey(executionKey));
193+
assertTrue(KeyStore.getInstance().size() == 1);
196194

197195
assertEquals(instanceId, workflowOutput.getWorkflowId());
198196
}

sdk-tests/src/test/java/io/dapr/it/testcontainers/KeyStore.java renamed to sdk-tests/src/test/java/io/dapr/it/testcontainers/workflows/KeyStore.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
* See the License for the specific language governing permissions and
1111
limitations under the License.
1212
*/
13-
package io.dapr.it.testcontainers;
13+
package io.dapr.it.testcontainers.workflows;
1414

1515
import java.util.HashMap;
1616
import java.util.Map;
@@ -48,4 +48,8 @@ public void removeKey(String key) {
4848
keyStore.remove(key);
4949
}
5050

51+
public int size() {
52+
return keyStore.size();
53+
}
54+
5155
}

sdk-tests/src/test/java/io/dapr/it/testcontainers/TaskExecutionKeyActivity.java renamed to sdk-tests/src/test/java/io/dapr/it/testcontainers/workflows/TaskExecutionIdActivity.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,20 +11,20 @@
1111
limitations under the License.
1212
*/
1313

14-
package io.dapr.it.testcontainers;
14+
package io.dapr.it.testcontainers.workflows;
1515

1616
import io.dapr.workflows.WorkflowActivity;
1717
import io.dapr.workflows.WorkflowActivityContext;
1818

19-
public class TaskExecutionKeyActivity implements WorkflowActivity {
19+
public class TaskExecutionIdActivity implements WorkflowActivity {
2020

2121
@Override
2222
public Object run(WorkflowActivityContext ctx) {
2323
TestWorkflowPayload workflowPayload = ctx.getInput(TestWorkflowPayload.class);
2424
KeyStore keyStore = KeyStore.getInstance();
25-
Boolean exists = keyStore.getKey(ctx.getTaskExecutionKey());
25+
Boolean exists = keyStore.getKey(ctx.getTaskExecutionId());
2626
if (!Boolean.TRUE.equals(exists)) {
27-
keyStore.addKey(ctx.getTaskExecutionKey(), true);
27+
keyStore.addKey(ctx.getTaskExecutionId(), true);
2828
workflowPayload.getPayloads().add("Execution key not found");
2929
throw new IllegalStateException("Task execution key not found");
3030
}

sdk-tests/src/test/java/io/dapr/it/testcontainers/TestExecutionKeysWorkflow.java renamed to sdk-tests/src/test/java/io/dapr/it/testcontainers/workflows/TestExecutionKeysWorkflow.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
limitations under the License.
1212
*/
1313

14-
package io.dapr.it.testcontainers;
14+
package io.dapr.it.testcontainers.workflows;
1515

1616
import io.dapr.durabletask.Task;
1717
import io.dapr.workflows.Workflow;
@@ -47,7 +47,7 @@ public WorkflowStub create() {
4747
.build());
4848

4949

50-
Task<TestWorkflowPayload> t = ctx.callActivity(TaskExecutionKeyActivity.class.getName(), workflowPayload, options,TestWorkflowPayload.class);
50+
Task<TestWorkflowPayload> t = ctx.callActivity(TaskExecutionIdActivity.class.getName(), workflowPayload, options,TestWorkflowPayload.class);
5151

5252
TestWorkflowPayload payloadAfterExecution = t.await();
5353

sdk-tests/src/test/java/io/dapr/it/testcontainers/workflows/TestWorkflowsConfiguration.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,9 @@ public WorkflowRuntimeBuilder workflowRuntimeBuilder(
6363

6464
builder.registerActivity(FirstActivity.class);
6565
builder.registerActivity(SecondActivity.class);
66+
builder.registerActivity(TaskExecutionIdActivity.class);
67+
68+
6669
builder.registerActivity("a",FirstActivity.class);
6770
builder.registerActivity("b",FirstActivity.class);
6871
builder.registerActivity("c", new SecondActivity());

sdk-workflows/src/main/java/io/dapr/workflows/WorkflowActivityContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public interface WorkflowActivityContext {
1717

1818
String getName();
1919

20-
String getTaskExecutionKey();
20+
String getTaskExecutionId();
2121

2222
<T> T getInput(Class<T> targetType);
2323

sdk-workflows/src/main/java/io/dapr/workflows/runtime/DefaultWorkflowActivityContext.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public <T> T getInput(Class<T> targetType) {
5858
}
5959

6060
@Override
61-
public String getTaskExecutionKey() {
62-
return this.innerContext.getTaskExecutionKey();
61+
public String getTaskExecutionId() {
62+
return this.innerContext.getTaskExecutionId();
6363
}
6464
}

sdk-workflows/src/test/java/io/dapr/workflows/runtime/WorkflowActivityClassWrapperTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public static class TestActivity implements WorkflowActivity {
1313
@Override
1414
public Object run(WorkflowActivityContext ctx) {
1515
String activityContextName = ctx.getName();
16-
return ctx.getInput(String.class) + " world! from " + activityContextName + " with task execution key " + ctx.getTaskExecutionKey();
16+
return ctx.getInput(String.class) + " world! from " + activityContextName + " with task execution key " + ctx.getTaskExecutionId();
1717
}
1818
}
1919

@@ -34,7 +34,7 @@ public void createWithClass() {
3434

3535
when(mockContext.getInput(String.class)).thenReturn("Hello");
3636
when(mockContext.getName()).thenReturn("TestActivityContext");
37-
when(mockContext.getTaskExecutionKey()).thenReturn("123");
37+
when(mockContext.getTaskExecutionId()).thenReturn("123");
3838

3939
Object result = wrapper.create().run(mockContext);
4040

0 commit comments

Comments
 (0)