Skip to content

Conversation

@SquidDev
Copy link
Contributor

@SquidDev SquidDev commented Aug 2, 2017

See #219 for a more detailed explanation and rational

  • Path containing / or \ are resolved relative to the current directory, rather than using the path. Paths starting with / still resolve relative to the root directory.
  • Shell completion will also include sub-directories of the current directory.

@Wojbie
Copy link
Contributor

Wojbie commented Aug 2, 2017

I don't think it currently works correctly.
Try this sequence of events:

cd rom
write/autocomplete to programs/time.lua

Expected result : runs time.lua
Got result: No such program

Worst thing is that it auto completed correctly.

@SquidDev SquidDev force-pushed the feature/shell-resolution branch 2 times, most recently from 11d17f4 to 5df97e5 Compare August 3, 2017 06:24
@SquidDev
Copy link
Contributor Author

SquidDev commented Aug 3, 2017

@Wojbie Apparently I failed to test execution from places which weren't the root directory, should be fixed now. Thanks for spotting it!

 - Path containing '/' or '\' are resolved relative to the current
   directory, rather than using the path. Paths starting with '/' still
   resolve relative to the root directory.
 - Shell completion will also include sub-directories of the current
   directory.

Closes dan200#219
@SquidDev SquidDev force-pushed the feature/shell-resolution branch from 5df97e5 to 4df92ff Compare June 3, 2018 21:11
ccserver pushed a commit to ccserver/ComputerCraft that referenced this pull request Sep 16, 2019
…shell-resolution

Tweak shell program resolution slightly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants