fix printing of report urls

Author: MarshalX

cycode/cli/printers/tables/sca_table_printer.py

@@ -51,7 +51,7 @@ def _print_results(self, local_scan_results: List['LocalScanResult']) -> None:
                 self._enrich_table_with_values(table, detection)
 
             self._print_summary_issues(len(detections), self._get_title(policy_id))
-            click.echo(table.get_table().draw())
+            self._print_table(table)
 
         self._print_report_urls(local_scan_results)
 
@@ -116,9 +116,12 @@ def _enrich_table_with_values(table: Table, detection: Detection) -> None:
 
     @staticmethod
     def _print_report_urls(local_scan_results: List['LocalScanResult']) -> None:
+        report_urls = [scan_result.report_url for scan_result in local_scan_results if scan_result.report_url]
+        if not report_urls:
+            return
+
         click.echo('Report URLs:')
-        for local_scan_result in local_scan_results:
-            report_url = local_scan_result.report_url if local_scan_result.report_url else 'N/A'
+        for report_url in report_urls:
             click.echo(f'- {report_url}')
 
     @staticmethod

cycode/cli/printers/tables/table_printer.py

@@ -65,7 +65,7 @@ def _print_results(self, local_scan_results: List['LocalScanResult']) -> None:
                     table.set(SCAN_ID_COLUMN, local_scan_result.scan_id)
                     self._enrich_table_with_values(table, detection, document_detections.document)
 
-        click.echo(table.get_table().draw())
+        self._print_table(table)
 
     def _get_table(self) -> Table:
         table = Table()
@@ -76,7 +76,6 @@ def _get_table(self) -> Table:
         table.add(LINE_NUMBER_COLUMN)
         table.add(COLUMN_NUMBER_COLUMN)
         table.add(SCAN_ID_COLUMN)
-        table.add(REPORT_URL_COLUMN)
 
         if self._is_git_repository():
             table.add(COMMIT_SHA_COLUMN)
@@ -86,6 +85,9 @@ def _get_table(self) -> Table:
             table.add(VIOLATION_LENGTH_COLUMN)
             table.add(VIOLATION_COLUMN)
 
+        if self.context.obj.get('report'):
+            table.add(REPORT_URL_COLUMN)
+
         return table
 
     def _enrich_table_with_values(self, table: Table, detection: Detection, document: Document) -> None:

cycode/cli/printers/tables/table_printer_base.py

@@ -9,6 +9,7 @@
 
 if TYPE_CHECKING:
     from cycode.cli.models import LocalScanResult
+    from cycode.cli.printers.tables.table import Table
 
 
 class TablePrinterBase(PrinterBase, abc.ABC):
@@ -36,3 +37,7 @@ def _is_git_repository(self) -> bool:
     @abc.abstractmethod
     def _print_results(self, local_scan_results: List['LocalScanResult']) -> None:
         raise NotImplementedError
+
+    @staticmethod
+    def _print_table(table: 'Table') -> None:
+        click.echo(table.get_table().draw())