Style: more standard code style for Neo.VM (neo-project#4022)

Co-authored-by: Christopher Schuchardt <[email protected]>
Co-authored-by: Shargon <[email protected]>

Author: 3 people

src/Neo.VM/EvaluationStack.cs

@@ -33,28 +33,6 @@ internal EvaluationStack(IReferenceCounter referenceCounter)
             _referenceCounter = referenceCounter;
         }
 
-        public StackItem this[int index]
-        {
-            get => Peek(index);
-        }
-
-        public IReadOnlyList<StackItem> this[Range range]
-        {
-            get
-            {
-                var start = range.Start.GetOffset(_innerList.Count);
-                var end = range.End.GetOffset(_innerList.Count);
-
-                if (start > end)
-                    throw new ArgumentOutOfRangeException("Range start must be less than or equal to end.");
-
-                StackItem[] copyList = [.. _innerList];
-                List<StackItem> reverseList = [.. copyList.Reverse()];
-
-                return reverseList.GetRange(start, end - start);
-            }
-        }
-
         /// <summary>
         /// Gets the number of items on the stack.
         /// </summary>

src/Neo.VM/Types/Integer.cs

@@ -54,7 +54,7 @@ public Integer(BigInteger value)
             {
                 Size = value.GetByteCount();
                 if (Size > MaxSize)
-                    throw new ArgumentException($"Integer size {Size} bytes exceeds maximum allowed size of {MaxSize} bytes.", nameof(value));
+                    throw new ArgumentException($"Can not create {nameof(Integer)}, MaxSize of {nameof(Integer)} is exceeded: {Size}/{MaxSize}.");
             }
             this.value = value;
         }

src/Neo.VM/Types/Map.cs

@@ -41,13 +41,13 @@ public StackItem this[PrimitiveType key]
             get
             {
                 if (key.Size > MaxKeySize)
-                    throw new ArgumentException($"Key size {key.Size} bytes exceeds maximum allowed size of {MaxKeySize} bytes.", nameof(key));
+                    throw new ArgumentException($"Can not get value from map, MaxKeySize of {nameof(Map)} is exceeded: {key.Size}/{MaxKeySize}.");
                 return _dict[key];
             }
             set
             {
                 if (key.Size > MaxKeySize)
-                    throw new ArgumentException($"Key size {key.Size} bytes exceeds maximum allowed size of {MaxKeySize} bytes.", nameof(key));
+                    throw new ArgumentException($"Can not set value to map, MaxKeySize of {nameof(Map)} is exceeded: {key.Size}/{MaxKeySize}.");
                 if (IsReadOnly) throw new InvalidOperationException("The map is readonly, can not set value.");
                 if (ReferenceCounter != null)
                 {
@@ -114,7 +114,7 @@ public override void Clear()
         public bool ContainsKey(PrimitiveType key)
         {
             if (key.Size > MaxKeySize)
-                throw new ArgumentException($"Key size {key.Size} bytes exceeds maximum allowed size of {MaxKeySize} bytes.", nameof(key));
+                throw new ArgumentException($"Can not check if map contains key, MaxKeySize of {nameof(Map)} is exceeded: {key.Size}/{MaxKeySize}.");
             return _dict.ContainsKey(key);
         }
 
@@ -154,7 +154,7 @@ IEnumerator IEnumerable.GetEnumerator()
         public bool Remove(PrimitiveType key)
         {
             if (key.Size > MaxKeySize)
-                throw new ArgumentException($"Key size {key.Size} bytes exceeds maximum allowed size of {MaxKeySize} bytes.", nameof(key));
+                throw new ArgumentException($"Can not remove key from map, MaxKeySize of {nameof(Map)} is exceeded: {key.Size}/{MaxKeySize}.");
             if (IsReadOnly) throw new InvalidOperationException("The map is readonly, can not remove key.");
             if (!_dict.Remove(key, out var oldValue)) return false;
             ReferenceCounter?.RemoveReference(key, this);
@@ -180,7 +180,7 @@ public bool TryGetValue(PrimitiveType key, [MaybeNullWhen(false)] out StackItem
 #pragma warning restore CS8767
         {
             if (key.Size > MaxKeySize)
-                throw new ArgumentException($"Key size {key.Size} bytes exceeds maximum allowed size of {MaxKeySize} bytes.", nameof(key));
+                throw new ArgumentException($"Can not get value from map, MaxKeySize of {nameof(Map)} is exceeded: {key.Size}/{MaxKeySize}.");
             return _dict.TryGetValue(key, out value);
         }
     }